feat(hooks): trigger hooks on product index and product show #18191

maximehuran · 2025-06-27T10:08:08Z

Q	A
Branch?	2.1
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Related tickets	no
License	MIT

To trigger some hooks like sylius_shop.product.index#metatags and sylius_shop.product.show#metatags

Summary by CodeRabbit

Chores
- Introduced new template variables for internal use without affecting existing page behavior or appearance.

coderabbitai · 2025-06-27T10:08:15Z

Walkthrough

A new Twig variable named prefixes is introduced at the top of both the product index and show template files. This variable is initialized as a list containing a context-specific string. No other changes to template logic or rendering behavior are made.

Changes

File(s)	Change Summary
src/Sylius/Bundle/ShopBundle/templates/product/index.html.twig, show.html.twig	Added a `prefixes` variable at the top, set to a context-specific string array. No other logic changed.

Suggested reviewers

mpysiak

Poem

A prefix here, a prefix there,
In templates now, they're everywhere!
Just a little string array,
To help the Twig along its way.
No logic changed, the code is neat—
Small tweaks make Sylius more complete!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1281070 and d3777a1.

📒 Files selected for processing (2)

src/Sylius/Bundle/ShopBundle/templates/product/index.html.twig (1 hunks)
src/Sylius/Bundle/ShopBundle/templates/product/show.html.twig (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

src/Sylius/Bundle/ShopBundle/templates/product/show.html.twig
src/Sylius/Bundle/ShopBundle/templates/product/index.html.twig

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Static checks / PHP 8.4, Symfony ^7.2
GitHub Check: Static checks / PHP 8.2, Symfony ^6.4
GitHub Check: Static checks / PHP 8.3, Symfony ^7.2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-06-27T10:09:18Z

❌ Preview Environment deleted from Bunnyshell

Available commands:

🚀 /bns:deploy to redeploy the environment

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/Sylius/Bundle/ShopBundle/templates/product/index.html.twig (1)
3-3: DRY the hook prefix to prevent string drift

The literal 'sylius_shop.product.index' now occurs twice (here and in the {% hook %} call below). If this identifier ever changes, it must be updated in two places, increasing maintenance overhead and the risk of subtle bugs.
-{% set prefixes = ['sylius_shop.product.index'] %}
+{% set _hookPrefix = 'sylius_shop.product.index' %}
+{% set prefixes   = [_hookPrefix] %}
Then replace the hard-coded string in the hook call:
-    {% hook 'sylius_shop.product.index' with { products, resources } %}
+    {% hook _hookPrefix with { products, resources } %}
src/Sylius/Bundle/ShopBundle/templates/product/show.html.twig (1)
3-3: Apply the same single-source-of-truth pattern as in the index template

For consistency and maintainability, consider introducing a dedicated variable for the hook name and reusing it in the {% hook %} invocation.
-{% set prefixes = ['sylius_shop.product.show'] %}
+{% set _hookPrefix = 'sylius_shop.product.show' %}
+{% set prefixes   = [_hookPrefix] %}
And below:
-    {% hook 'sylius_shop.product.show' with { product, configuration } %}
+    {% hook _hookPrefix with { product, configuration } %}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8632aac and 1281070.

📒 Files selected for processing (2)

src/Sylius/Bundle/ShopBundle/templates/product/index.html.twig (1 hunks)
src/Sylius/Bundle/ShopBundle/templates/product/show.html.twig (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Static checks / PHP 8.3, Symfony ^7.2
GitHub Check: Static checks / PHP 8.4, Symfony ^7.2
GitHub Check: Static checks / PHP 8.2, Symfony ^6.4

src/Sylius/Bundle/ShopBundle/templates/product/index.html.twig

GSadee

I’ve tested this once again and compared it with my proposal from the review. I’m fine with this change, as it properly differentiates the product show and index pages and, as a result, allows us to define things like different meta tags for each of them.

maximehuran requested review from a team as code owners June 27, 2025 10:08

probot-autolabeler bot added the Shop ShopBundle related issues and PRs. label Jun 27, 2025

coderabbitai bot reviewed Jun 27, 2025

View reviewed changes

GSadee reviewed Jul 2, 2025

View reviewed changes

src/Sylius/Bundle/ShopBundle/templates/product/index.html.twig Show resolved Hide resolved

GSadee force-pushed the feature/product-hooks branch from 1281070 to d3777a1 Compare July 2, 2025 11:47

GSadee approved these changes Dec 15, 2025

View reviewed changes

feat(hooks): trigger hooks on product index and product show

6d0ceac

GSadee force-pushed the feature/product-hooks branch from d3777a1 to 6d0ceac Compare December 15, 2025 06:53

GSadee merged commit 0a417bf into Sylius:2.1 Dec 15, 2025
36 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(hooks): trigger hooks on product index and product show #18191

feat(hooks): trigger hooks on product index and product show #18191

Uh oh!

maximehuran commented Jun 27, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 27, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jun 27, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

GSadee left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

feat(hooks): trigger hooks on product index and product show #18191

feat(hooks): trigger hooks on product index and product show #18191

Uh oh!

Conversation

maximehuran commented Jun 27, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

GSadee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

maximehuran commented Jun 27, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jun 27, 2025 •

edited

Loading