[SHOP][FEATURE] Introduce address form modifiers in checkout component #18410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… form value modifications
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bc126d0 to
f35dda5
Compare
… update UPGRADE guide for 2.2 transition.
f35dda5 to
8d66168
Compare
Prometee
requested changes
Oct 3, 2025
src/Sylius/Bundle/ShopBundle/Twig/Component/Checkout/Address/FormComponent.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Twig/Component/Checkout/Address/FormComponent.php
Outdated
Show resolved
Hide resolved
❌ Preview Environment deleted from BunnyshellAvailable commands:
|
Prometee
reviewed
Oct 3, 2025
Comment on lines
84
to
97
| $newAddress['firstName'] = $address->getFirstName(); | ||
| $newAddress['lastName'] = $address->getLastName(); | ||
| $newAddress['phoneNumber'] = $address->getPhoneNumber(); | ||
| $newAddress['company'] = $address->getCompany(); | ||
| $newAddress['countryCode'] = $address->getCountryCode(); | ||
| if ($address->getProvinceCode() !== null) { | ||
| $newAddress['provinceCode'] = $address->getProvinceCode(); | ||
| } | ||
| if ($address->getProvinceName() !== null) { | ||
| $newAddress['provinceName'] = $address->getProvinceName(); | ||
| } | ||
| $newAddress['street'] = $address->getStreet(); | ||
| $newAddress['city'] = $address->getCity(); | ||
| $newAddress['postcode'] = $address->getPostcode(); |
Contributor
There was a problem hiding this comment.
This can be removed if the DefaultAddressFormValuesModifier is declared as a service.
Rafikooo
reviewed
Oct 6, 2025
src/Sylius/Bundle/ShopBundle/Modifier/DefaultAddressFormValuesModifier.php
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Twig/Component/Checkout/Address/FormComponent.php
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Twig/Component/Checkout/Address/FormComponent.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Modifier/DefaultAddressFormValuesModifier.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Modifier/AddressFormValuesModifierInterface.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Twig/Component/Checkout/Address/FormComponent.php
Outdated
Show resolved
Hide resolved
b38ac6c to
e9b11d3
Compare
…troduce `DefaultAddressFormValuesModifier`.
e9b11d3 to
5e78b96
Compare
Prometee
approved these changes
Oct 7, 2025
Rafikooo
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new mechanism for extending the checkout address
FormComponentvia tagged services implementingAddressFormValuesModifierInterface.This approach uses dependency injection and a tagged_iterator with the tag
sylius_shop.modifier.address_form_values. These modifiers allow plugins and applications to dynamically transform or enrich the address data.