Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Rafikooo
Copy link
Contributor

@Rafikooo Rafikooo commented Nov 28, 2025

Migrates shop promotion tests from Panther to ChromeDriver. The goal is to fully migrate to a single driver.

@Rafikooo Rafikooo requested review from a team as code owners November 28, 2025 22:35
@coderabbitai
Copy link

coderabbitai bot commented Nov 28, 2025

Walkthrough

Replace Behat test runner tags from @javascript to @mink:chromedriver across promotion-related feature files in the shop module, affecting 9 test scenarios without modifying test logic or assertions.

Changes

Cohort / File(s) Summary
Catalog promotions applying
features/shop/promotion/applying_catalog_promotions/applying_catalog_promotions_for_product.feature, features/shop/promotion/applying_catalog_promotions/seeing_applied_catalog_promotion_on_variant.feature
Updated scenario tags from @javascript to @mink:chromedriver
Catalog promotions with options
features/shop/promotion/applying_catalog_promotions/e2e/ui/seeing_applied_catalog_promotion_on_products_with_options.feature
Replaced @javascript with @mink:chromedriver in all four scenarios
Promotion coupon management
features/shop/promotion/applying_promotion_coupon/e2e/applying_promotion_coupon.feature, features/shop/promotion/applying_promotion_coupon/e2e/removing_promotion_coupon.feature
Updated scenario tags from @javascript to @mink:chromedriver

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Homogeneous change pattern across 5 files with 9 affected scenarios
  • Pure tagging/configuration change with no test logic modifications

Possibly related PRs

Suggested labels

Behat, Maintenance

Suggested reviewers

  • GSadee
  • mpysiak

Poem

🐰 Chrome drivers now steer the wheel,

Where JavaScript once held appeal,

Nine tests retag with careful aim,

Same logic, different driver name! 🚗✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: migrating Behat shop promotion scenarios from @javascript to @mink:chromedriver.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Nov 28, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

@Rafikooo Rafikooo changed the title [Behat] Migrate shop promotion tests to chromedriver [Behat] Migrate shop promotion scenarios to chromedriver Nov 30, 2025
@Rafikooo Rafikooo changed the title [Behat] Migrate shop promotion scenarios to chromedriver [Behat] Migrate shop promotion scenarios to chromedriver Nov 30, 2025
@Wojdylak Wojdylak merged commit a0f2784 into Sylius:2.1 Dec 1, 2025
67 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants