Add A2C Implementation #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f52b86 to
9afabc1
Compare
ryanmccann1024
approved these changes
Mar 18, 2025
Requests' status dictionary was not being reset.
Also, add test and plot modules for RL.
Also, change some script names for clarity or unnecessary length.
We were not tracking the algorithm name properly. Also, add an excel module.
Also change seed vs. reward funciton.
We didn't return properly for the SB3 callback, leading to a short episode 'hidden' episode leading to an impossible reward in the first episode in the next trial.
Have q_learning save in the same format as the bandits.
We weren't plotting for all algorithms.
Changed to box plots. Also, remove some commented code.
Also, add test and plot modules for RL.
Also, change some script names for clarity or unnecessary length.
…mplement # Conflicts: # reinforcement_learning/agents/base_agent.py # reinforcement_learning/args/registry_args.py # reinforcement_learning/plot/run_plots.py # sb3_scripts/yml/ppo.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added files and functions needed to implement a new Actor to Critic algorithm using Stable-baseline 3.
Type of Change
Additions were made to the following files:
-rl_scripts/agents/base_agent.py
-rl_scripts/args/general_args.py
-rl_scripts/args/regirstrly_args.py
-rl_scripts/helpers/setup_helpers.py
The following files were added:
-rl_scripts/algorithms/a2c.py
-sb3_scripts/yml/a2c.yml
How has this change been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Also, list any relevant details for your test configuration.
No test configurations have been added at this time.
Does change comply with project standards and guideline?
Standards and guidelines can be found on the Project Homepage.