Conversation
|
Oh what a list! Thanks for putting this together, even though many fixes won't have a direct effect on CSFML's API. Need to update the ci.yml to use the 2.6.x branch (and later 2.6.0 tag) CSFML/.github/workflows/ci.yml Line 28 in 39d7c47 |
b5b3924 to
5b8acd2
Compare
|
Someone Might want to test the packets getter function added in this function 5b8acd2 . I haven't got the slightest idea as to how I would test it. |
|
I managed to hack through the entire list for all of the obvious ones that don't need updates on CSFML's end. The rest of the unchecked issues / PRs are ones that I wasn't sure needed changes to CSFML's end, or one's that need changes to CSFML's end. If you could help me go through the rest of this list, that would be grand. |
|
To make sure I understand, you went through every PR after |
To be specific, I got the changelog.md change from this PR https://github.com/SFML/SFML/pull/2482/files?diff=unified&w=0 and parsed all of the numbers for matching pull requests. |
|
@ChrisThrasher I should also add, there are already a couple of additions in this pull request. I have font smoothing disabling (a feature I REALLY want on rust-sfml), and some networking feature already committed. |
ChrisThrasher
left a comment
There was a problem hiding this comment.
Just a few simple formatting fixes to get started
|
Re-triggered the job runs, now that the |
|
Can we move this list into a separate issue that we can incrementally tackle these changes over multiple PRs? That will make it easier for multiple people to work concurrently if need be. We can still merge the progress already made in this PR. |
|
See #187 for this same list but in a separate issue. Please do not use this particular PR for more work progress tracking. |
|
Marked it as non-draft. You can merge it now. |
Also added a check for whether the font is smoothing
|
Thank you for getting this started! 🙂 |
This PR will be for getting all of the 2.6.x features into CSFML. Here is a test project that I have an open source to test the project with. Currently, I have font enabled and disabled by pressing the s key https://github.com/dogunbound/CSFML_2.6_sample
I hope we can hack this out. 2.6.x is pretty stable, so I think it would be good to begin working on this.
Basically, we need to slowly go through EVERY pull request and see if any change needs to be made and make those changes. If there aren't any changes needed for a specific pull request, mark it as complete.
todo list:
sf::LockSFML#1848-Wunused-parameter,-Wsign-compare) SFML#1785-Wmissing-braceswarning under clang (for SFML 2.6) SFML#2048ActivityStatesSFML#1845sf::Context::getActiveContextto stop returning inactive contexts SFML#1794JoystickImplwith too many file descriptors SFML#1941sf::Musicsometimes failing to loop after seeking SFML#1707