Allow enabling of TLS verification without supplying CRL file #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional certificate validation error logging
|
LGTM |
|
@wdoekes Any chance this can make it into the next patch release? |
|
I think it looks good. No sudden camelCase please though: And not sure why the "\n" in the WARNING. Right now I count: 87 WARNINGs without LF and 5 ones with. Are all the other WARNINGs without LF bad? |
My bad, will fix!
Yes, they cause log messages to concatenate in one long line. |
Fair enough. |
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CRL file specified via
tls_crl_nameflag is being loaded even if it wasn't supplied, causing TLS initialisation to fail:This PR ensures that custom behaviour caused by
SSL_VERIFY_PEERcan be enabled without supplying CRL file.