Include the SNI for SSL client #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orgads
reviewed
Sep 11, 2024
|
Thank you! |
orgads
reviewed
Sep 11, 2024
|
Please squash the commits. |
b7765a5 to
c548875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SNI for SSL client only.
As SSL related function applies any input into the SNI extension, a minimal validation was added to ignore IP endpoint.
From wireshark, the TLS handshake has visible differences
sipp -t l1 -sn uac <server_as_hostname>:5061sipp -t l1 -sn uac <server_as_direct_ip>:5061fixes #753