Claude suggested this:

unsigned int generate_seed() {
    unsigned int seed = (unsigned int)time(NULL);
    seed ^= (unsigned int)clock();
    seed ^= (unsigned int)getpid();
    
    struct timespec ts;
    if (clock_gettime(CLOCK_MONOTONIC, &ts) == 0) {
        seed ^= (unsigned int)ts.tv_nsec;
    }
    
    return seed;
}

WDYS?

Claude suggested this:

unsigned int generate_seed() {
    unsigned int seed = (unsigned int)time(NULL);
    seed ^= (unsigned int)clock();
    seed ^= (unsigned int)getpid();
    
    struct timespec ts;
    if (clock_gettime(CLOCK_MONOTONIC, &ts) == 0) {
        seed ^= (unsigned int)ts.tv_nsec;
    }
    
    return seed;
}

WDYS?

I don't think we gain from mixing 3 different time-based values (time(), clock() and clock_gettime()) - that still gives only time-based uniqueness. So I'd probably just take clock_gettime()'s nanoseconds and forget about time() and clock() in that case, because it's incredibly unlikely that two processes call that in the same ns.

However, clock_getres() might indicate the resolution isn't really to the nanosecond. Since we don't know the resolution of the clock across systems that sipp might run on, I thought it was better to grab other sources of uniqueness (PID and hostname).

But a suggestion like this would almost definitely solve my problem too :)

Claude suggested this:

unsigned int generate_seed() {
    unsigned int seed = (unsigned int)time(NULL);
    seed ^= (unsigned int)clock();
    seed ^= (unsigned int)getpid();
    
    struct timespec ts;
    if (clock_gettime(CLOCK_MONOTONIC, &ts) == 0) {
        seed ^= (unsigned int)ts.tv_nsec;
    }
    
    return seed;
}

WDYS?

I don't think we gain from mixing 3 different time-based values (time(), clock() and clock_gettime()) - that still gives only time-based uniqueness. So I'd probably just take clock_gettime()'s nanoseconds and forget about time() and clock() in that case, because it's incredibly unlikely that two processes call that in the same ns.

However, clock_getres() might indicate the resolution isn't really to the nanosecond. Since we don't know the resolution of the clock across systems that sipp might run on, I thought it was better to grab other sources of uniqueness (PID and hostname).

But a suggestion like this would almost definitely solve my problem too :)

Sounds good. So can you implement it?

Sounds good. So can you implement it?

Yep, updated to XOR with the nanosecond value too :)

Any idea why the test fails?

@jeannotlanglois ?

Rebased and it passed. Merging.

Thanks for your persistence @FalacerSelene!