Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Clang formatter for all source codes #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Clang formatter for all source codes #1524

wants to merge 0 commits into from

Conversation

@cubicYYY
Copy link
Contributor

All source codes are now formatted.
clang-format.sh is now introduced and should be run before committing.

The .clang-format file is updated and is used for formatting. It is now corresponding to a style like the status quo.

@cubicYYY cubicYYY marked this pull request as draft August 21, 2024 16:47
@codecov
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 75.40492% with 410 lines in your changes missing coverage. Please review.

Project coverage is 65.58%. Comparing base (02fa4ef) to head (445f975).

Files Patch % Lines
svf-llvm/lib/DCHG.cpp 0.00% 152 Missing ⚠️
svf-llvm/tools/AE/ae.cpp 44.06% 33 Missing ⚠️
svf-llvm/lib/LLVMModule.cpp 80.48% 24 Missing ⚠️
svf-llvm/tools/MTA/LockResultValidator.cpp 27.27% 24 Missing ⚠️
svf-llvm/lib/LLVMUtil.cpp 85.96% 16 Missing ⚠️
svf-llvm/tools/MTA/MTAResultValidator.cpp 73.07% 14 Missing ⚠️
svf-llvm/lib/CHGBuilder.cpp 86.51% 12 Missing ⚠️
svf-llvm/lib/SVFIRExtAPI.cpp 76.47% 12 Missing ⚠️
svf-llvm/lib/CppUtil.cpp 86.07% 11 Missing ⚠️
svf-llvm/tools/MTA/MTAAnnotator.cpp 0.00% 11 Missing ⚠️
... and 28 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
+ Coverage   65.42%   65.58%   +0.16%     
==========================================
  Files         256      256              
  Lines       26920    25856    -1064     
  Branches     4807     4949     +142     
==========================================
- Hits        17612    16958     -654     
+ Misses       9308     8898     -410
Files Coverage Δ
svf-llvm/include/SVF-LLVM/BreakConstantExpr.h 33.33% <ø> (ø)
svf-llvm/include/SVF-LLVM/CHGBuilder.h 100.00% <100.00%> (ø)
svf-llvm/include/SVF-LLVM/GEPTypeBridgeIterator.h 93.10% <100.00%> (-0.45%) ⬇️
svf-llvm/include/SVF-LLVM/ICFGBuilder.h 100.00% <100.00%> (ø)
svf-llvm/include/SVF-LLVM/LLVMLoopAnalysis.h 100.00% <ø> (ø)
svf-llvm/include/SVF-LLVM/LLVMModule.h 91.83% <100.00%> (+1.54%) ⬆️
svf-llvm/include/SVF-LLVM/ObjTypeInference.h 100.00% <ø> (ø)
svf-llvm/include/SVF-LLVM/SymbolTableBuilder.h 100.00% <100.00%> (ø)
svf-llvm/lib/ICFGBuilder.cpp 100.00% <100.00%> (ø)
svf-llvm/lib/LLVMLoopAnalysis.cpp 100.00% <100.00%> (ø)
... and 244 more

@cubicYYY cubicYYY marked this pull request as ready for review August 21, 2024 18:54
@cubicYYY
Copy link
Contributor Author

cubicYYY commented Aug 21, 2024 •
edited
Loading

Some optional tasks to do in or not in this PR:

  • Add a workflow to check the format
  • Acquire a contributor to run the formatting script before committing, in docs.

@yuleisui
Copy link
Collaborator

Could you make the format change automatically by changing the GitHub action here:

SVF/.github/workflows/svf-lib_publish.yml

Line 54 in a9be281

- name: code-format-and-build-svf

@cubicYYY cubicYYY closed this Aug 24, 2024
@cubicYYY cubicYYY mentioned this pull request Aug 24, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cubicYYY @yuleisui