Add BH properties from HYBRID model #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subfind and HBT do not output bound particles for subhalos.
* Virtual snapshot contains link to membership files instead
of a copy of the data
* Use absolute paths to the underlying files
Conflicts:
group_membership.py
FHusko
reviewed
Sep 3, 2024
aperture_properties.py
Outdated
| "BHmaxvel", | ||
| "BHmaxAR", | ||
| "BHmaxlasteventa", | ||
| "BlackHolesTotalInjectedEnergy", |
There was a problem hiding this comment.
One small thing: could you add an equivalent of this quantity, BlackHolesTotalInjectedJetEnergy, that is defined as the sum over all injected jet energies from all the BHs?
|
@VictorForouhar can you please approve, Filip doesn't have permission |
VictorForouhar
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two different flavours of COLIBRE - thermal only AGN feedback and hybrid AGN feedback. The hybrid runs output some additional BH properties which we don't have for the thermal model. This PR adds these new properties, and also a couple of extra properties for the thermal runs.
This requires a separate parameter file for the thermal and hybrid runs. We also need to take into account that the COLIBRE snipshots can't calculate all the same properties as the snapshot. Rather than having 4 parameter files, I have added some functionality to the parameter file reader such that we can specify properties as on/off in snipshots. I have added a new runtime option (
--snipshot) which should be passed tocompute_halo_properties.pywhen running on a snipshot.An additional minor change is to remove the test parameter files, and generate them when running the tests. This is done by the
tests/COLIBRE/create_parameters_file.pyscript.