Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 6, 2022. It is now read-only.

Add Challenge preview card #85

Merged
merged 15 commits into from
Jul 2, 2021
Merged

Add Challenge preview card #85

merged 15 commits into from
Jul 2, 2021

Conversation

@rrchai
Copy link
Contributor

@rrchai rrchai commented Jun 28, 2021 •
edited
Loading

fix #81

Add card (within a tab panel) component to preview challenges info with local challenges data using material. Can make card as independent components if needed.

UI demo :
preview-card

@rrchai rrchai marked this pull request as ready for review June 28, 2021 19:24
@rrchai rrchai requested a review from tschaffter June 28, 2021 19:24
vpchung
vpchung reviewed Jul 1, 2021
View reviewed changes
Copy link
Member

@vpchung vpchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, @rrchai !

I commented on a couple of things that could either be tackled now in the alpha version or maybe keep in mind for later (maybe the platform team will handle it?).

@tschaffter tschaffter changed the title Challenge preview card Add Challenge preview card Jul 1, 2021
tschaffter
tschaffter suggested changes Jul 1, 2021
View reviewed changes
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as @vpchung . I also opened a PR that targets this PR to rename the component and remove unused code from the initial app, see #90 .

@rrchai
Merge pull request #90 from Sage-Bionetworks/rename-component
865d5c8 
Rename component preview-card to challenge-preview
This was referenced Jul 2, 2021
Open
Open
tschaffter
tschaffter approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tschaffter tschaffter merged commit 5eb8102 into main Jul 2, 2021
@tschaffter tschaffter deleted the challenge-preview-card branch July 2, 2021 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@vpchung vpchung vpchung left review comments

@tschaffter tschaffter tschaffter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rrchai rrchai

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create Challenge card

4 participants

@rrchai @tschaffter @vpchung