Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Sandakan
Copy link
Owner

@Sandakan Sandakan commented May 29, 2023

  • Will add this feature to the next update

With Howler, Nora may be able to play songs from the following codecs.

  • "mp3": true
  • "mpeg": true
  • "opus": true
  • "ogg": true
  • "oga": true
  • "wav": true
  • "aac": true
  • "m4a": true
  • "m4b": true
  • "mp4": true
  • "weba": true
  • "webm": true
  • "flac": true
  • "caf": false
  • "dolby": false

But there are some problems with using Howler.

  1. If web audio API is selected to be used in Howler, users won't be able to control Nora through keyboard media controls.
  2. If HTML5 API is selected to be used in Howler, users won't be able to use the Equalizer in Nora.
  3. I tried to play some songs with the codecs listed above. Some worked as expected but m4a didn't work. And other codecs marked false also won't work on Nora due to environmental issues.

Therefore it seems like howler integration is not worth losing all other useful features for some codec support which may or may not work.

I will keep code related to Howler in the Howler branch until I can find a solution for the problems. But until then it will be better to not push it in the next update.

Suggestions are welcome about this.

@Sandakan Sandakan self-assigned this May 29, 2023
@Sandakan Sandakan merged commit 2e187f5 into minor-release Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants