Sandakan · Sandakan · Sep 9, 2023 · Jul 16, 2023 · Jul 23, 2023 · Jul 30, 2023
diff --git a/.erb/configs/webpack.config.renderer.dev.ts b/.erb/configs/webpack.config.renderer.dev.ts
@@ -21,7 +21,7 @@ const port = process.env.PORT || 5500;
 const manifest = path.resolve(webpackPaths.dllPath, 'renderer.json');
 // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
 const requiredByDLLConfig = module.parent!.filename.includes(
-  'webpack.config.renderer.dev.dll'
+  'webpack.config.renderer.dev.dll',
 );
 
 /**
@@ -33,8 +33,8 @@ if (
 ) {
   console.log(
     chalk.black.bgYellow.bold(
-      'The DLL files are missing. Sit back while we build them for you with "npm run build-dll"'
-    )
+      'The DLL files are missing. Sit back while we build them for you with "npm run build-dll"',
+    ),
   );
   execSync('npm run postinstall');
 }

diff --git a/.erb/scripts/check-build-exists.ts b/.erb/scripts/check-build-exists.ts
@@ -10,15 +10,15 @@ const rendererPath = path.join(webpackPaths.distRendererPath, 'renderer.js');
 if (!fs.existsSync(mainPath)) {
   throw new Error(
     chalk.whiteBright.bgRed.bold(
-      'The main process is not built yet. Build it by running "npm run build:main"'
-    )
+      'The main process is not built yet. Build it by running "npm run build:main"',
+    ),
   );
 }
 
 if (!fs.existsSync(rendererPath)) {
   throw new Error(
     chalk.whiteBright.bgRed.bold(
-      'The renderer process is not built yet. Build it by running "npm run build:renderer"'
-    )
+      'The renderer process is not built yet. Build it by running "npm run build:renderer"',
+    ),
   );
 }
diff --git a/.erb/scripts/check-native-dep.js b/.erb/scripts/check-native-dep.js
@@ -16,34 +16,34 @@ if (dependencies) {
     // because of a devDependency then that is okay. Warn when it is installed
     // because of a dependency
     const { dependencies: dependenciesObject } = JSON.parse(
-      execSync(`npm ls ${nativeDeps.join(' ')} --json`).toString()
+      execSync(`npm ls ${nativeDeps.join(' ')} --json`).toString(),
     );
     const rootDependencies = Object.keys(dependenciesObject);
     const filteredRootDependencies = rootDependencies.filter((rootDependency) =>
-      dependenciesKeys.includes(rootDependency)
+      dependenciesKeys.includes(rootDependency),
     );
     if (filteredRootDependencies.length > 0) {
       const plural = filteredRootDependencies.length > 1;
       console.log(`
  ${chalk.whiteBright.bgYellow.bold(
-   'Webpack does not work with native dependencies.'
+   'Webpack does not work with native dependencies.',
  )}
 ${chalk.bold(filteredRootDependencies.join(', '))} ${
         plural ? 'are native dependencies' : 'is a native dependency'
       } and should be installed inside of the "./release/app" folder.
  First, uninstall the packages from "./package.json":
 ${chalk.whiteBright.bgGreen.bold('npm uninstall your-package')}
  ${chalk.bold(
-   'Then, instead of installing the package to the root "./package.json":'
+   'Then, instead of installing the package to the root "./package.json":',
  )}
 ${chalk.whiteBright.bgRed.bold('npm install your-package')}
  ${chalk.bold('Install the package to "./release/app/package.json"')}
 ${chalk.whiteBright.bgGreen.bold(
-  'cd ./release/app && npm install your-package'
+  'cd ./release/app && npm install your-package',
 )}
  Read more about native dependencies at:
 ${chalk.bold(
-  'https://electron-react-boilerplate.js.org/docs/adding-dependencies/#module-structure'
+  'https://electron-react-boilerplate.js.org/docs/adding-dependencies/#module-structure',
 )}
  `);
       process.exit(1);

diff --git a/.erb/scripts/check-node-env.js b/.erb/scripts/check-node-env.js
@@ -8,8 +8,8 @@ export default function checkNodeEnv(expectedEnv) {
   if (process.env.NODE_ENV !== expectedEnv) {
     console.log(
       chalk.whiteBright.bgRed.bold(
-        `"process.env.NODE_ENV" must be "${expectedEnv}" to use this webpack config`
-      )
+        `"process.env.NODE_ENV" must be "${expectedEnv}" to use this webpack config`,
+      ),
     );
     process.exit(2);
   }

diff --git a/.erb/scripts/check-port-in-use.js b/.erb/scripts/check-port-in-use.js
@@ -7,8 +7,8 @@ detectPort(port, (err, availablePort) => {
   if (port !== String(availablePort)) {
     throw new Error(
       chalk.whiteBright.bgRed.bold(
-        `Port "${port}" on "localhost" is already in use. Please use another port. ex: PORT=4343 npm start`
-      )
+        `Port "${port}" on "localhost" is already in use. Please use another port. ex: PORT=4343 npm start`,
+      ),
     );
   } else {
     process.exit(0);

diff --git a/.erb/scripts/notarize.js b/.erb/scripts/notarize.js
@@ -14,7 +14,7 @@ exports.default = async function notarizeMacos(context) {
 
   if (!('APPLE_ID' in process.env && 'APPLE_ID_PASS' in process.env)) {
     console.warn(
-      'Skipping notarizing step. APPLE_ID and APPLE_ID_PASS env variables must be set'
+      'Skipping notarizing step. APPLE_ID and APPLE_ID_PASS env variables must be set',
     );
     return;
   }

diff --git a/.eslintrc.js b/.eslintrc.js
@@ -40,6 +40,7 @@ module.exports = {
     'react/jsx-filename-extension': 'off',
     'no-restricted-syntax': 'off',
     'import/named': 'off',
+    'no-use-before-define': ['error', { functions: false }],
   },
   overrides: [
     {

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -30,10 +30,6 @@ jobs:
           node-version: 18
           check-latest: true
 
-      - name: Print GitHub Ref
-        run: |
-          echo "GitHub Ref: ${{ github.ref }}"
-
       - name: Build/release Electron app
         uses: samuelmeuli/action-electron-builder@v1
         with:

diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -0,0 +1,4 @@
+#!/usr/bin/env sh
+. "$(dirname -- "$0")/_/husky.sh"
+
+npm run husky-test
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -20,10 +20,15 @@
     "Resyncing",
     "RIELL",
     "samuelmeuli",
+    "scrobble",
     "Spicetify",
     "sspai",
+    "SYLT",
+    "unlove",
     "unmaximize",
+    "unmaximized",
     "unsynced",
+    "USLT",
     "webm",
     "xmark",
     "Yosef",
@@ -58,7 +63,8 @@
     "class",
     "className",
     "ngClass",
-    "iconClassName"
+    "iconClassName",
+    "titleClassName"
   ],
   "editor.tokenColorCustomizations": {
     "comments": "",

diff --git a/README.md b/README.md
@@ -5,7 +5,7 @@
 
  <div align="center">
   <img alt="GitHub all releases" src="https://img.shields.io/github/downloads/Sandakan/Nora/total?label=all%20time%20downloads&style=for-the-badge">
-  <img alt="GitHub release (latest by date)" src="https://img.shields.io/github/downloads/Sandakan/Nora/v2.3.0-stable/total?style=for-the-badge">
+  <img alt="GitHub release (latest by date)" src="https://img.shields.io/github/downloads/Sandakan/Nora/v2.4.0-stable/total?style=for-the-badge">
   <img alt="GitHub package.json version" src="https://img.shields.io/github/package-json/v/Sandakan/Nora?color=blue&label=latest%20version&style=for-the-badge">
   <a href="https://github.com/Sandakan/Nora/blob/master/LICENSE"><img alt="GitHub license" src="https://img.shields.io/github/license/Sandakan/Nora?style=for-the-badge"></a>
   <a href="https://github.com/Sandakan/Nora/issues"><img alt="GitHub issues" src="https://img.shields.io/github/issues/Sandakan/Oto-Music-for-Desktop?style=for-the-badge"></a>
@@ -58,7 +58,7 @@ It packs a horizon of features including,
 
 <br>
 
-![Latest Version Artwork](/assets/other/release%20artworks/whats-new-v2.3.0-stable.webp)
+![Latest Version Artwork](/assets/other/release%20artworks/whats-new-v2.4.0-stable.webp)
 
 Visit the [release notes](/changelog.md) to see what's new on the latest release.</p>
 
@@ -68,6 +68,8 @@ Visit the [release notes](/changelog.md) to see what's new on the latest release
 
 ![Switch between Dark and Light Modes Artwork](/assets/other/artwork%202.webp)
 
+![Support for Last.FM Scrobbling](/assets/other/artwork%209.webp)
+
 ![Organize your music library with ease Artwork](/assets/other/artwork%203.webp)
 
 ![See how your favorite artists appear on songs and albums Artwork](/assets/other/artwork%204.webp)

diff --git a/__tests__/isLatestVersion.test.ts b/__tests__/isLatestVersion.test.ts
@@ -15,13 +15,13 @@ describe('App versions check', () => {
 
   test('Versions with same release phases and different build metadata', () => {
     expect(
-      isLatestVersion('2.0.0-stable.20230515', '2.0.0-stable.20230510')
+      isLatestVersion('2.0.0-stable.20230515', '2.0.0-stable.20230510'),
     ).toBe(true);
     expect(isLatestVersion('2.0.0-beta20230510', '2.0.0-beta20230515')).toBe(
-      true
+      true,
     );
     expect(
-      isLatestVersion('2.0.0-alpha.20250101', '2.0.0-alpha.19990509')
+      isLatestVersion('2.0.0-alpha.20250101', '2.0.0-alpha.19990509'),
     ).toBe(true);
   });
 

diff --git a/assets/fonts/MaterialSymbolsRounded.woff2 b/assets/fonts/MaterialSymbolsRounded.woff2
diff --git a/assets/images/webp/last-fm-logo.webp b/assets/images/webp/last-fm-logo.webp
diff --git a/assets/installer_assets/sidebar.bmp b/assets/installer_assets/sidebar.bmp
diff --git a/assets/other/artwork 9.webp b/assets/other/artwork 9.webp
diff --git a/assets/other/release artworks/whats-new-v2.4.0-stable.webp b/assets/other/release artworks/whats-new-v2.4.0-stable.webp
diff --git a/assets/styles/styles.css b/assets/styles/styles.css
@@ -158,15 +158,20 @@ body,
 
 body,
 body * {
-  transition: color var(--transition-duration-0_2s) linear,
+  transition:
+    color var(--transition-duration-0_2s) linear,
     background-color var(--transition-duration-0_2s) linear;
-  -webkit-transition: color var(--transition-duration-0_2s) linear,
+  -webkit-transition:
+    color var(--transition-duration-0_2s) linear,
     background-color var(--transition-duration-0_2s) linear;
-  -moz-transition: color var(--transition-duration-0_2s) linear,
+  -moz-transition:
+    color var(--transition-duration-0_2s) linear,
     background-color var(--transition-duration-0_2s) linear;
-  -ms-transition: color var(--transition-duration-0_2s) linear,
+  -ms-transition:
+    color var(--transition-duration-0_2s) linear,
     background-color var(--transition-duration-0_2s) linear;
-  -o-transition: color var(--transition-duration-0_2s) linear,
+  -o-transition:
+    color var(--transition-duration-0_2s) linear,
     background-color var(--transition-duration-0_2s) linear;
 }
 

diff --git a/changelog.md b/changelog.md
@@ -1,10 +1,64 @@
 # Change Log
 
-> ### The latest version, **( v2.3.0-stable )** contains a lot of new features and improvements. As always expect some bugs in the app.
+> ### The latest version, **( v2.4.0-stable )** contains a lot of new features and improvements. As always expect some bugs in the app.
 
 <br>
 
-![Nora v2.3.0-stable version artwork](assets/other/release%20artworks/whats-new-v2.3.0-stable.webp)
+![Nora v2.4.0-stable version artwork](assets/other/release%20artworks/whats-new-v2.4.0-stable.webp)
+
+<br>
+
+- ### **v2.4.0-stable - ( 09<sup>th</sup> of September 2023 )**
+
+- ### 🎉 New Features and Updates
+
+  - Added support for authenticating Last.FM users from Nora.
+  - Added support for Last.Fm scrobbling. Fixes #187.
+  - Added support for sending favorites data to Last.Fm.
+  - Added support for sending now-playing song info to Last.FM.
+  - Added a feature that shows similar artists and relevant hashtags for an artist when in the ArtistInfopage.
+  - Added a feature that shows similar tracks of a song when in the SongInfoPage.
+  - Added a feature that shows unavailable tracks and a summary of the album when in the AlbumInfoPage.
+  - Added support for saving the window state so that Nora starts from the previous window state (e.g.: full-screen).
+  - Added support for viewing both synchronized and Un-synchronized lyrics in the SongTagsEditingPage.
+  - Added a pane to display additional info about the song in the SongInfoPage.
+  - Added a new `Account Settings` section to the SettingsPage.
+  - Added icons to buttons in the LyricsEditingPage.
+  - Added a button to go to LyricsEditingPage from the LyricsPage.
+  - Added an alert in the SongTagsEditingPage if there are pending lyrics to be written to a song.
+  - Added an option to display song track number instead of the index number when in Albums Info Page. Fixes #194.
+
+- ### 🔨 Fixes and Improvements
+
+  - Fixed a bug where suggestion prompts don't hide when clicked on the button with an up arrow.
+  - Updated the feature to edit the next line's start tag with the current line's end tag and vice versa automatically.
+  - Fixed a bug where saved lyrics will be overwritten if the user selected the 'Synchronized Lyrics Only' or 'Un-synchronized and Synchronized Lyrics Only' options to save lyrics automatically and clicked the 'Show Online Lyrics' button.
+  - Fixed a bug where ignoring DuplicateArtistsSuggestions and SeparateArtistsSuggestions are not working.
+  - Fixed a bug where the 'No lyrics found' message will be shown in the LyricsPage when you try to view online lyrics that are not available for a song but have offline lyrics.
+  - Improved performance when displaying songs in CurrentQueuePage.
+  - Improved app logs to display the destination of the log.
+  - Improved app performance and reduced time taken when opening songs from File Explorer.
+  - Improved performance when opening Albums, Playlists, and Genres with bigger song lists.
+  - Updated outdated dependencies and fixed dependency vulnerabilities.
+  - Updated some icons in the app.
+  - Fixed a bug where saving automatically downloaded lyrics may confuse the audio player to skip the song. Fixes #192.
+  - Fixed a bug where ignoring DuplicateArtistsSuggestions and SeparateArtistsSuggestions are not working.
+  - Fixed a bug where automatically downloaded lyrics may try to save to songs that do not support modifying song metadata.
+  - Fixed a bug where songs show the original artwork instead of the optimized artwork and sometimes may fail to load the optimized artwork.
+  - Fixed a bug where duplicate album entries are added to artists when songs with the same album and artist are parsed. Fixes #191.
+  - Fixed a bug where the sorting state of songs in MusicFoldersPage is not being saved.
+  - Fixed a bug where search results from SongTagsEditingPage for artists, albums, and genres are fixed to a maximum limit of 5.
+  - Fixed a bug where clicking 'Play All' shuffles the queue.
+  - Fixed a bug where Ctrl + Click an item doesn't select it.
+  - Fixed a bug where user cannot use Shift + Click and Control + Click selection combinations simultaneously.
+  - Fixed a bug where suggestions don't get minimized when the up-arrow button is clicked.
+
+- ### 🐜 Known Issues and Bugs
+  - Nora may fail to load some FLAC songs #184.
+
+<br>
+
+![Nora v2.3.0-stable version artwork](assets/other/release%20artworks/whats-new-v2.4.0-stable.webp)
 
 <br>
 
@@ -64,6 +118,10 @@
 
 <br>
 
+![Nora v2.2.0-stable version artwork](assets/other/release%20artworks/whats-new-v2.2.0-stable.webp)
+
+<br>
+
 - ### **v2.2.0-stable - ( 20<sup>th</sup> of May 2023 )**
 
   - ### 🎉 New Features and Features
@@ -91,6 +149,10 @@
 
 <br>
 
+![Nora v2.1.0-stable version artwork](assets/other/release%20artworks/whats-new-v2.1.0-stable.webp)
+
+<br>
+
 - ### **v2.1.0-stable - ( 13<sup>th</sup> of May 2023 )**
 
   - ### 🎉 New Features and Features
@@ -143,6 +205,10 @@
 
 <br>
 
+![Nora v2.0.0-stable version artwork](assets/other/release%20artworks/whats-new-v2.0.0-stable.webp)
+
+<br>
+
 - ### **v2.0.0-stable - ( 23<sup>th</sup> of April 2023 )**
 
   - ### 🎉 New Features and Features
@@ -247,6 +313,10 @@
 
 <br>
 
+![Nora v1.2.0-stable version artwork](assets/other/release%20artworks/whats-new-v1.2.0-stable.webp)
+
+<br>
+
 - ### **v1.2.0-stable - ( 9<sup>th</sup> of March 2023 )**
 
   - ### 🎉 New Features and Features
@@ -284,6 +354,10 @@
 
 <br>
 
+![Nora v1.1.0-stable version artwork](assets/other/release%20artworks/whats-new-v1.1.0-stable.webp)
+
+<br>
+
 - ### **v1.1.0-stable - ( 26<sup>th</sup> of February 2023 )**
 
   - ### 🎉 New Features and Features
@@ -322,6 +396,10 @@
 
 <br>
 
+![Nora v1.0.0-stable version artwork](assets/other/release%20artworks/whats-new-v1.0.0-stable.webp)
+
+<br>
+
 - ### **v1.0.0-stable - ( 17<sup>th</sup> of February 2023 )**
 
   - ### 🎉 New Features and Updates
@@ -440,6 +518,10 @@
 
 <br>
 
+![Nora v0.8.0-alpha version artwork](assets/other/release%20artworks/whats-new-v0.8.0-alpha.webp)
+
+<br>
+
 - ### **v0.8.0-alpha - ( 19<sup>th</sup> of August 2022 )**
 
   - ### 🎉 New Features and Updates
@@ -474,6 +556,10 @@
 
 <br>
 
+![Nora v0.7.0-alpha version artwork](assets/other/release%20artworks/whats-new-v0.7.0-alpha.webp)
+
+<br>
+
 - ### **v0.7.0-alpha - ( 27<sup>th</sup> of July 2022 )**
 
   - ### 🎉 New Features and Updates