Sandakan · Sandakan · Sep 10, 2023 · May 28, 2023 · May 28, 2023 · May 28, 2023
diff --git a/.erb/configs/webpack.config.renderer.dev.ts b/.erb/configs/webpack.config.renderer.dev.ts
@@ -21,7 +21,7 @@ const port = process.env.PORT || 5500;
 const manifest = path.resolve(webpackPaths.dllPath, 'renderer.json');
 // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
 const requiredByDLLConfig = module.parent!.filename.includes(
-  'webpack.config.renderer.dev.dll'
+  'webpack.config.renderer.dev.dll',
 );
 
 /**
@@ -33,8 +33,8 @@ if (
 ) {
   console.log(
     chalk.black.bgYellow.bold(
-      'The DLL files are missing. Sit back while we build them for you with "npm run build-dll"'
-    )
+      'The DLL files are missing. Sit back while we build them for you with "npm run build-dll"',
+    ),
   );
   execSync('npm run postinstall');
 }

diff --git a/.erb/scripts/check-build-exists.ts b/.erb/scripts/check-build-exists.ts
@@ -10,15 +10,15 @@ const rendererPath = path.join(webpackPaths.distRendererPath, 'renderer.js');
 if (!fs.existsSync(mainPath)) {
   throw new Error(
     chalk.whiteBright.bgRed.bold(
-      'The main process is not built yet. Build it by running "npm run build:main"'
-    )
+      'The main process is not built yet. Build it by running "npm run build:main"',
+    ),
   );
 }
 
 if (!fs.existsSync(rendererPath)) {
   throw new Error(
     chalk.whiteBright.bgRed.bold(
-      'The renderer process is not built yet. Build it by running "npm run build:renderer"'
-    )
+      'The renderer process is not built yet. Build it by running "npm run build:renderer"',
+    ),
   );
 }
diff --git a/.erb/scripts/check-native-dep.js b/.erb/scripts/check-native-dep.js
@@ -16,34 +16,34 @@ if (dependencies) {
     // because of a devDependency then that is okay. Warn when it is installed
     // because of a dependency
     const { dependencies: dependenciesObject } = JSON.parse(
-      execSync(`npm ls ${nativeDeps.join(' ')} --json`).toString()
+      execSync(`npm ls ${nativeDeps.join(' ')} --json`).toString(),
     );
     const rootDependencies = Object.keys(dependenciesObject);
     const filteredRootDependencies = rootDependencies.filter((rootDependency) =>
-      dependenciesKeys.includes(rootDependency)
+      dependenciesKeys.includes(rootDependency),
     );
     if (filteredRootDependencies.length > 0) {
       const plural = filteredRootDependencies.length > 1;
       console.log(`
  ${chalk.whiteBright.bgYellow.bold(
-   'Webpack does not work with native dependencies.'
+   'Webpack does not work with native dependencies.',
  )}
 ${chalk.bold(filteredRootDependencies.join(', '))} ${
         plural ? 'are native dependencies' : 'is a native dependency'
       } and should be installed inside of the "./release/app" folder.
  First, uninstall the packages from "./package.json":
 ${chalk.whiteBright.bgGreen.bold('npm uninstall your-package')}
  ${chalk.bold(
-   'Then, instead of installing the package to the root "./package.json":'
+   'Then, instead of installing the package to the root "./package.json":',
  )}
 ${chalk.whiteBright.bgRed.bold('npm install your-package')}
  ${chalk.bold('Install the package to "./release/app/package.json"')}
 ${chalk.whiteBright.bgGreen.bold(
-  'cd ./release/app && npm install your-package'
+  'cd ./release/app && npm install your-package',
 )}
  Read more about native dependencies at:
 ${chalk.bold(
-  'https://electron-react-boilerplate.js.org/docs/adding-dependencies/#module-structure'
+  'https://electron-react-boilerplate.js.org/docs/adding-dependencies/#module-structure',
 )}
  `);
       process.exit(1);

diff --git a/.erb/scripts/check-node-env.js b/.erb/scripts/check-node-env.js
@@ -8,8 +8,8 @@ export default function checkNodeEnv(expectedEnv) {
   if (process.env.NODE_ENV !== expectedEnv) {
     console.log(
       chalk.whiteBright.bgRed.bold(
-        `"process.env.NODE_ENV" must be "${expectedEnv}" to use this webpack config`
-      )
+        `"process.env.NODE_ENV" must be "${expectedEnv}" to use this webpack config`,
+      ),
     );
     process.exit(2);
   }

diff --git a/.erb/scripts/check-port-in-use.js b/.erb/scripts/check-port-in-use.js
@@ -7,8 +7,8 @@ detectPort(port, (err, availablePort) => {
   if (port !== String(availablePort)) {
     throw new Error(
       chalk.whiteBright.bgRed.bold(
-        `Port "${port}" on "localhost" is already in use. Please use another port. ex: PORT=4343 npm start`
-      )
+        `Port "${port}" on "localhost" is already in use. Please use another port. ex: PORT=4343 npm start`,
+      ),
     );
   } else {
     process.exit(0);

diff --git a/.erb/scripts/notarize.js b/.erb/scripts/notarize.js
@@ -14,7 +14,7 @@ exports.default = async function notarizeMacos(context) {
 
   if (!('APPLE_ID' in process.env && 'APPLE_ID_PASS' in process.env)) {
     console.warn(
-      'Skipping notarizing step. APPLE_ID and APPLE_ID_PASS env variables must be set'
+      'Skipping notarizing step. APPLE_ID and APPLE_ID_PASS env variables must be set',
     );
     return;
   }

diff --git a/.eslintrc.js b/.eslintrc.js
@@ -19,6 +19,7 @@ module.exports = {
     'react/function-component-definition': 'off',
     'default-param-last': 'off',
     'import/prefer-default-export': 'off',
+    'promise/catch-or-return': [2, { allowFinally: true }],
     'import/no-unresolved': [2, { caseSensitive: false }],
     radix: ['warn', 'as-needed'],
     'react/no-unescaped-entities': [
@@ -39,6 +40,7 @@ module.exports = {
     'react/jsx-filename-extension': 'off',
     'no-restricted-syntax': 'off',
     'import/named': 'off',
+    'no-use-before-define': ['error', { functions: false }],
   },
   overrides: [
     {

diff --git a/.gitattributes b/.gitattributes
@@ -0,0 +1 @@
+* text=auto eol=lf
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
@@ -2,7 +2,7 @@
 name: Bug report
 about: Create a report to help us improve
 title: Bug in Nora
-labels: bug, good first issue
+labels: bug
 assignees: Sandakan
 ---
 
@@ -30,7 +30,7 @@ It is situated in C:\Users\USER_NAME\AppData\Roaming\nora\logs.txt
 **System Information:**
 
 - OS: [e.g. Windows 10]
-- Affected App Version: [e.g.>=0.8.0-alpha]
+- Affected App Version: [e.g.>=2.0.0-stable]
 
 **Additional context**
 Add any other context about the problem here.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -4,6 +4,9 @@ on:
   push:
     branches: ['master']
 
+  pull_request:
+    branches: ['master']
+
 env:
   MUSIXMATCH_DEFAULT_USER_TOKEN: ${{ secrets.MUSIXMATCH_DEFAULT_USER_TOKEN }}
   LAST_FM_API_KEY: ${{ secrets.LAST_FM_API_KEY }}
@@ -36,6 +39,6 @@ jobs:
 
           # If the commit is tagged with a version (e.g. "v1.0.0"),
           # release the app after building
-          release: true
-          # release: ${{ startsWith(github.ref, 'refs/heads/master') }}
+          # release: true
+          release: ${{ startsWith(github.ref, 'refs/heads/master')}}
           # release: ${{ startsWith(github.ref, 'refs/tags/v') }}
diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -0,0 +1,4 @@
+#!/usr/bin/env sh
+. "$(dirname -- "$0")/_/husky.sh"
+
+npm run husky-test
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -6,6 +6,7 @@
     "Brainz",
     "Deezer",
     "ecfg",
+    "EXTM",
     "Fashni",
     "FXJOE",
     "horiz",
@@ -19,10 +20,15 @@
     "Resyncing",
     "RIELL",
     "samuelmeuli",
+    "scrobble",
     "Spicetify",
     "sspai",
+    "SYLT",
+    "unlove",
     "unmaximize",
+    "unmaximized",
     "unsynced",
+    "USLT",
     "webm",
     "xmark",
     "Yosef",
@@ -57,6 +63,11 @@
     "class",
     "className",
     "ngClass",
-    "iconClassName"
-  ]
+    "iconClassName",
+    "titleClassName"
+  ],
+  "editor.tokenColorCustomizations": {
+    "comments": "",
+    "textMateRules": []
+  }
 }
diff --git a/README.md b/README.md
@@ -1,11 +1,11 @@
  <h1 align="center">
-   <img class="logo" src="assets/images/webp/logo_light_mode.webp" width="60px">
-   <p>Nora Player</p>
+   <img class="logo" src="assets/other/nora_logo_banner.webp">
+   <!-- <p>Nora Player</p> -->
  </h1>
 
  <div align="center">
   <img alt="GitHub all releases" src="https://img.shields.io/github/downloads/Sandakan/Nora/total?label=all%20time%20downloads&style=for-the-badge">
-  <img alt="GitHub release (latest by date)" src="https://img.shields.io/github/downloads/Sandakan/Nora/v2.2.0-stable/total?style=for-the-badge">
+  <img alt="GitHub release (latest by date)" src="https://img.shields.io/github/downloads/Sandakan/Nora/v2.4.0-stable/total?style=for-the-badge">
   <img alt="GitHub package.json version" src="https://img.shields.io/github/package-json/v/Sandakan/Nora?color=blue&label=latest%20version&style=for-the-badge">
   <a href="https://github.com/Sandakan/Nora/blob/master/LICENSE"><img alt="GitHub license" src="https://img.shields.io/github/license/Sandakan/Nora?style=for-the-badge"></a>
   <a href="https://github.com/Sandakan/Nora/issues"><img alt="GitHub issues" src="https://img.shields.io/github/issues/Sandakan/Oto-Music-for-Desktop?style=for-the-badge"></a>
@@ -58,7 +58,7 @@ It packs a horizon of features including,
 
 <br>
 
-![Latest Version Artwork](/assets/other/release%20artworks/whats-new-v2.2.0-stable.webp)
+![Latest Version Artwork](/assets/other/release%20artworks/whats-new-v2.4.0-stable.webp)
 
 Visit the [release notes](/changelog.md) to see what's new on the latest release.</p>
 
@@ -68,6 +68,8 @@ Visit the [release notes](/changelog.md) to see what's new on the latest release
 
 ![Switch between Dark and Light Modes Artwork](/assets/other/artwork%202.webp)
 
+![Support for Last.FM Scrobbling](/assets/other/artwork%209.webp)
+
 ![Organize your music library with ease Artwork](/assets/other/artwork%203.webp)
 
 ![See how your favorite artists appear on songs and albums Artwork](/assets/other/artwork%204.webp)
@@ -86,6 +88,19 @@ Visit the [release notes](/changelog.md) to see what's new on the latest release
 
 <br>
 
+<div align="center"> 
+  <div>
+    <h3><i>" A sleek music player with a modern design, this solution seeks to provide users with a seamless experience when it comes to listening to their favorite local tunes. "</i></h3>
+    <a href="https://www.softpedia.com/get/Multimedia/Audio/Audio-Players/Oto-Music-for-Desktop.shtml"><i>Robert Condorache &bull; Softpedia </i></a>
+  </div> 
+</div>
+
+<br>
+
+<div align="center"> &bull; &bull; &bull; </div>
+
+<br>
+
 <div align="center"> 
   <div>
     <h3><i>" The application interface adopts rounded corners in a large area, the fonts and icons are round and cute, and the visual effect is very comfortable. "</i></h3>

diff --git a/__tests__/isLatestVersion.test.ts b/__tests__/isLatestVersion.test.ts
@@ -15,13 +15,13 @@ describe('App versions check', () => {
 
   test('Versions with same release phases and different build metadata', () => {
     expect(
-      isLatestVersion('2.0.0-stable.20230515', '2.0.0-stable.20230510')
+      isLatestVersion('2.0.0-stable.20230515', '2.0.0-stable.20230510'),
     ).toBe(true);
     expect(isLatestVersion('2.0.0-beta20230510', '2.0.0-beta20230515')).toBe(
-      true
+      true,
     );
     expect(
-      isLatestVersion('2.0.0-alpha.20250101', '2.0.0-alpha.19990509')
+      isLatestVersion('2.0.0-alpha.20250101', '2.0.0-alpha.19990509'),
     ).toBe(true);
   });
 

diff --git a/assets/fonts/MaterialSymbolsRounded.woff2 b/assets/fonts/MaterialSymbolsRounded.woff2
diff --git a/assets/images/webp/last-fm-logo.webp b/assets/images/webp/last-fm-logo.webp
diff --git a/assets/installer_assets/sidebar.bmp b/assets/installer_assets/sidebar.bmp
diff --git a/assets/other/artwork 9.webp b/assets/other/artwork 9.webp
diff --git a/assets/other/nora_logo_banner.webp b/assets/other/nora_logo_banner.webp
diff --git a/assets/other/release artworks/whats-new-v2.3.0-stable.webp b/assets/other/release artworks/whats-new-v2.3.0-stable.webp
diff --git a/assets/other/release artworks/whats-new-v2.4.0-stable.webp b/assets/other/release artworks/whats-new-v2.4.0-stable.webp
diff --git a/assets/styles/styles.css b/assets/styles/styles.css
@@ -158,15 +158,20 @@ body,
 
 body,
 body * {
-  transition: color var(--transition-duration-0_2s) linear,
+  transition:
+    color var(--transition-duration-0_2s) linear,
     background-color var(--transition-duration-0_2s) linear;
-  -webkit-transition: color var(--transition-duration-0_2s) linear,
+  -webkit-transition:
+    color var(--transition-duration-0_2s) linear,
     background-color var(--transition-duration-0_2s) linear;
-  -moz-transition: color var(--transition-duration-0_2s) linear,
+  -moz-transition:
+    color var(--transition-duration-0_2s) linear,
     background-color var(--transition-duration-0_2s) linear;
-  -ms-transition: color var(--transition-duration-0_2s) linear,
+  -ms-transition:
+    color var(--transition-duration-0_2s) linear,
     background-color var(--transition-duration-0_2s) linear;
-  -o-transition: color var(--transition-duration-0_2s) linear,
+  -o-transition:
+    color var(--transition-duration-0_2s) linear,
     background-color var(--transition-duration-0_2s) linear;
 }