Migrated PR to 3.1 - Added customization of shortcuts #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as previous PR in the master branch, cleaned the switch case, added shortcuts customization, added a list of missing cases, to be done later. Stored in local storage so should be exportable easily. Everything should be conform and using dynamic colors. Nothing has been added to the i18n files, todo soon.
Owner
|
What a nice feature. Thank you for the help. 🙏 |
Sandakan
requested changes
Mar 29, 2025
src/renderer/src/components/SettingsPage/AppShortcutsPrompt.tsx
Outdated
Show resolved
Hide resolved
Everything has been moved to LocalStorage structure and has also been added to the LOCAL_STORAGE_DEFAULT. I also fixed every issue you mentioned such as types and usage of your already made buttons, I can confirm they are waay better haha. I added another resetItem function to make it easier to reset the keyboardShortcuts and can be useful for future functions. I also tried to reset, export and import and everything worked perfectly !
Contributor
Author
|
Hello, I think it is done, is there anything more that is needed and you want to be added ? |
Sandakan
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as previous PR in the master branch but this time to the 3.1 minor release branch, cleaned the switch case, added shortcuts customization, added a list of missing cases, to be done later. Stored in local storage so should be exportable easily. Everything should be conform and using dynamic colors. Nothing has been added to the i18n files, todo soon.
If any shortcut is missing please send a comment I will add it, I might have forgotten some shortcuts or oversimplified some even though I tried my best to not miss any.