forked from zcash/halo2
-
Couldn't load subscription status.
- Fork 0
Lookup example #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Schaeff
wants to merge
21
commits into
main
Choose a base branch
from
lookup-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use biimplication in the correctness argument to ensure both soundness and completeness; * avoid introducing lambda at all; it's unnecessary and omitting it shortens the explanation. Co-authored-by: Jack Grigg <[email protected]> Signed-off-by: Daira Hopwood <[email protected]>
This changes variable names in the multiopen and commitment opening implementations and the book's protocol description to keep names and indicies consistent with one another. Co-Authored-By: Jack Grigg <[email protected]>
…patibility testing
Add hardcoded proof to plonk_api test
halo2_proofs: rename variables for consistency
The verifier's check in the inner product argument used to assume that the G'_0 value had an additional (trivial) blinding factor term, which makes it slightly easier to reason that it never is the point at infinity. However, we never sample challenges that are zeroes (both for security and completeness reasons) so this element would never be the point at infinity anyway. Thus, we can simplify the check with the added benefit of matching the book's description of the protocol.
halo2_proofs: change IPA check equation to match the book
Improve the explanation of incomplete addition
`halo2 0.1.0-beta.2` etc.
CI updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.