More workflow refactors, cleanups #2195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to bcd5178 in 1 minute and 46 seconds. Click for details.
- Reviewed
265lines of code in8files - Skipped
0files when reviewing. - Skipped posting
8draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. py/core/__init__.py:103
- Draft comment:
Removed 'increment_version' from all. Ensure no downstream code depends on this versioning helper. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to ensure that no downstream code depends on the removed function. This is a request for confirmation, which violates the rules. The comment does not provide a specific code suggestion or ask for a specific test to be written.
2. py/core/base/__init__.py:120
- Draft comment:
Removed 'increment_version' from all in the base module. Verify that versioning isn't relied upon elsewhere. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to verify that the removal ofincrement_versionfrom__all__does not affect other parts of the codebase. This is a request for verification, which is against the rules. The comment does not provide a specific suggestion or ask for a specific test to be written.
3. py/core/base/utils/__init__.py:14
- Draft comment:
Removed 'decrement_version' and 'increment_version' from imports/exports. Confirm that these utilities are no longer needed. - Reason this comment was not posted:
Comment looked like it was already resolved.
4. py/core/main/orchestration/simple/ingestion_workflow.py:240
- Draft comment:
Removed the update_files function and its usage (e.g., increment_version call). Ensure that this change is intentional and that clients use the supported ingestion paths. - Reason this comment was not posted:
Comment looked like it was already resolved.
5. py/core/main/services/ingestion_service.py:899
- Draft comment:
Removed the parse_update_files_input method from IngestionServiceAdapter. Verify that file update ingestion is no longer needed. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to verify that a certain functionality is no longer needed. This falls under the rule of not asking the author to confirm their intention or to ensure behavior is intended. Therefore, this comment should be removed.
6. py/core/utils/__init__.py:14
- Draft comment:
Removed 'decrement_version' and 'increment_version' exports. This cleanup appears consistent; double-check that no consumers require these functions. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to double-check that no consumers require the removed functions. This violates the rule against asking the author to confirm or double-check things.
7. py/shared/utils/__init__.py:13
- Draft comment:
Removed 'decrement_version' and 'increment_version' from shared utils exports. Confirm this refactor is backward‐compatible with any shared usage. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to confirm backward compatibility, which is against the rules. It does not provide a specific suggestion or ask for a specific test to be written. Therefore, it should be removed.
8. py/shared/utils/base_utils.py:180
- Draft comment:
Removed the definitions for 'increment_version' and 'decrement_version'. Ensure that version management no longer depends on these functions. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to ensure that version management no longer depends on the removed functions. This is a request for confirmation, which violates the rule against asking the author to ensure behavior is intended or to double-check things.
Workflow ID: wflow_V6aZPWvm7TLqxaIN
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Remove
increment_version,decrement_version, and related references, along withupdate_filesandparse_update_files_inputfunctions, to streamline the codebase.increment_versionanddecrement_versionfunctions frombase_utils.py.update_filesfunction fromingestion_workflow.py.parse_update_files_inputfunction fromingestion_service.py.increment_versionanddecrement_versionin__init__.pyfiles incore,core/base,core/base/utils,core/utils, andshared/utils.asyncioimport fromingestion_workflow.py.This description was created by
for bcd5178. You can customize this summary. It will automatically update as commits are pushed.