Update search_file_knowledge.py to fix filtering issue #2192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to a4865b9 in 59 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. py/core/base/agent/tools/built_in/search_file_knowledge.py:59
- Draft comment:
The keyword argument was changed from 'settings' to 'search_settings'. Ensure that this matches the expected parameter name of the underlying knowledge_search_method. Also, update the adjacent comment if needed for consistency. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_hBKgumPjK7Ui4RJg
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fix parameter name in
execute()ofSearchFileKnowledgeToolto prevent silent failure insearch_file_knowledge.py.settingstosearch_settingsinexecute()method ofSearchFileKnowledgeToolinsearch_file_knowledge.py.knowledge_search_methodcall due to incorrect parameter name.This description was created by
for a4865b9. You can customize this summary. It will automatically update as commits are pushed.