This repository was archived by the owner on Feb 17, 2023. It is now read-only.
Added AsDataTypeArray and the Array.astype method. #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
>>> biggus.zeros(3).astype('i4')[:2]
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/data/local/ithr/miniconda/envs/biggus/lib/python2.7/site-packages/biggus/__init__.py", line 538, in __getitem__
indexed_array = self._getitem_full_keys(keys)
File "/data/local/ithr/miniconda/envs/biggus/lib/python2.7/site-packages/biggus/__init__.py", line 662, in _getitem_full_keys
return self.array._getitem_full_keys(keys)
File "/data/local/ithr/miniconda/envs/biggus/lib/python2.7/site-packages/biggus/__init__.py", line 556, in _getitem_full_keys
raise NotImplementedError('_getitem_full_keys should be overridden.')
NotImplementedError: _getitem_full_keys should be overridden.And that's why I like abstract methods... 😉 |
|
No comment re abstract methods... I've added a commit which fixes the bug with |
|
Anything holding this back from being merged @rhattersley? |
rhattersley
added a commit
that referenced
this pull request
Apr 10, 2015
Added AsDataTypeArray and the Array.astype method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was one of the things I thought of on my 🚲 this morning.