Add support for Geostationary coord_system #5745
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5745 +/- ##
========================================
Coverage 89.71% 89.72%
========================================
Files 90 91 +1
Lines 22815 22924 +109
Branches 5438 5462 +24
========================================
+ Hits 20468 20568 +100
- Misses 1617 1622 +5
- Partials 730 734 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trexfeathers
requested changes
Feb 15, 2024
There was a problem hiding this comment.
Thanks @stephenworsley! It's presumably on your radar to add tests to cover each of these changes?
|
@trexfeathers Yes that's the plan, I just need to figure out how to get the appropriate test data. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5485
Supports the cannonical coordinates of the Geostationary coord system (
projection_x_angular_coordinate,projection_y_angular_coordinate) and their cannonical unit (radians).