greptimedb: Add version 0.17.1 #7181
Conversation
WalkthroughAdds a new Scoop manifest for GreptimeDB at bucket/greptimedb.json specifying version 0.17.1, metadata, 64-bit download URL with SHA256, extract_dir, exposed binary, checkver from GitHub, and autoupdate rules. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. greptimedb
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
bucket/greptimedb.json (4)
14-16: Use owner/repo in checkver.github (not a full URL).Scoop’s checkver expects "github": "Owner/Repo". Using a URL may break automatic version detection.
"checkver": { - "github": "https://github.com/GreptimeTeam/greptimedb" + "github": "GreptimeTeam/greptimedb" },
17-24: Add autoupdate.hash to enable automatic checksum updates.Without a hash rule,
checkver -uwon’t be able to update the checksum automatically.Option A (if a per‑asset .sha256 is published):
"autoupdate": { "architecture": { "64bit": { "url": "https://github.com/GreptimeTeam/greptimedb/releases/download/v$version/greptime-windows-amd64-v$version.tar.gz", + "hash": { + "url": "$url.sha256" + }, "extract_dir": "greptime-windows-amd64-v$version" } } }If the project publishes a single checksums file instead, point to it and add a regex for the asset’s SHA256. I can tailor the rule once you confirm the checksums artifact name.
3-3: Tighten the description to neutral, concise wording.Short, non‑marketing summaries are preferred in Scoop manifests.
- "description": "Open-source, cloud-native, unified observability database for metrics, logs and traces, supporting SQL/PromQL/Streaming. Available on GreptimeCloud.", + "description": "Open-source, cloud-native observability database for metrics, logs, and traces; supports SQL/PromQL/streaming.",
6-12: Optional: Add arm64 architecture if an official Windows arm64 asset exists.If Greptime publishes a Windows arm64 tarball, include it to improve coverage.
"architecture": { "64bit": { "url": "https://github.com/GreptimeTeam/greptimedb/releases/download/v0.17.1/greptime-windows-amd64-v0.17.1.tar.gz", "hash": "148299e077edca9f812bb16e0b456f86be6f7338fddbf811c08c3f2d681ace1d", "extract_dir": "greptime-windows-amd64-v0.17.1" - } + }, + "arm64": { + "url": "https://github.com/GreptimeTeam/greptimedb/releases/download/v0.17.1/greptime-windows-arm64-v0.17.1.tar.gz", + "hash": "<sha256-arm64>", + "extract_dir": "greptime-windows-arm64-v0.17.1" + } },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/greptimedb.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (2)
bucket/greptimedb.json (2)
13-13: Confirm greptime.exe path after extraction.With extract_dir set, bin should be relative to that directory. Validate that the executable is at greptime.exe (not nested deeper).
8-11: Verified — release asset URL, extract_dir, and SHA256 match for v0.17.1.Top-level folder in tarball: greptime-windows-amd64-v0.17.1; SHA256: 148299e077edca9f812bb16e0b456f86be6f7338fddbf811c08c3f2d681ace1d.
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit