Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@niheaven
Copy link
Member

@niheaven niheaven commented May 9, 2024

Description

Skip caching deprecated manifest.

It would be more effective to assign a flag to deprecated items, as maintainers often transfer manifests from the main bucket to the deprecated one, and this would allow users to search for them as well.

Motivation and Context

How Has This Been Tested?

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@junlongzzz
Copy link

我觉得不应该使用排除,而是指定为 bucket 文件夹内的清单文件
比如这个 https://github.com/chawyehsu/dorado/tree/master/experiment 文件夹内的也被扫描到了,但安装时也提示无效

@niheaven
Copy link
Member Author

niheaven commented May 9, 2024

Legacy buckets place manifests in the root folder, which prevents the inclusion of bucket. Therefore, only deprecated can be excluded, as it is specified in our official bucket template.

@junlongzzz
Copy link

okay

@niheaven niheaven merged commit edaae8d into develop May 9, 2024
@niheaven niheaven deleted the fix-sqlite branch May 9, 2024 12:15
@chawyehsu
Copy link
Member

Instead of adding filters, it should use Find-BucketDirectory to locate manifest directory, the same way scoop search, without the sqlite, is using...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants