Rewrite enum and text casting #973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyt2y3
reviewed
Aug 20, 2022
tyt2y3
reviewed
Aug 20, 2022
tyt2y3
reviewed
Aug 20, 2022
src/query/helper.rs
Outdated
| fn cast_enum_text_inner<C, F>(expr: Expr, col: &C, f: F) -> SimpleExpr | ||
| where | ||
| C: ColumnTrait, | ||
| F: Fn(Expr, &String) -> SimpleExpr, |
There was a problem hiding this comment.
Same here, I might have lost the context, but why are we passing enum name around as String? Can we pass around DynIden instead?
There was a problem hiding this comment.
The String comes from ColumnType::Enum
Line 81 in 87f7891
I rewrite it into F: Fn(Expr, DynIden) -> SimpleExpr, but still, we need to wrap the String as DynIden like SeaRc::new(Alias::new(enum_name))
There was a problem hiding this comment.
Um... I think we should have used an Iden here. Second question is, how often is this ColumnType object being cloned? If it is being cloned frequently then we'd better Arc it. At the very least I think a named struct serves as a better documentation:
EnumDef {
name: DynIden,
variants: Vec<DynIden>,
}
3 tasks
tyt2y3
pushed a commit
that referenced
this pull request
Sep 30, 2022
* Rewrite enum and text casting * Add doc tests * Refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
fn column()also handle enum type #960Adds
QuerySelect::columnmethod also handle enum typeChanges