Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Support deriving ActiveEnum without importing some types #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2022
Merged

fix: Support deriving ActiveEnum without importing some types #1146

merged 2 commits into from
Oct 26, 2022

Conversation

@siketyan
Copy link
Contributor

@siketyan siketyan commented Oct 24, 2022 •
edited
Loading

PR Info

  • Dependencies:
    • N/A
  • Dependents:
    • N/A

Adds

N/A

Fixes

  • Canonicalised usages of types with sea_orm:: prefix to enable derives without importing the types
    • Either importing sea_orm::sea_query or depending on sea_query crate is still needed due to types derived in sea_query_derive crate

Breaking Changes

N/A

Changes

N/A

siketyan
siketyan commented Oct 24, 2022
View reviewed changes
sea-orm-macros/src/lib.rs Outdated
/// # Usage
///
/// ```
/// use sea_orm::{sea_query, EnumIter, DeriveActiveEnum};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we do not need to import Iden, EnumIter nor ActiveEnum, but sea_query is still needed.

This was linked to issues Oct 26, 2022
DeriveActiveEnum requires sea-query #1151
Closed
sea_orm::DeriveActiveEnum now requires some modules and types are imported since v0.10.0 #1143
Closed
@siketyan
Copy link
Contributor Author

Hi @billy1624 , thank you for triaging this pull request!
I think #1151 will NOT be resolved by this changes.

billy1624
billy1624 reviewed Oct 26, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @siketyan, thanks for helping!!

Hi @billy1624 , thank you for triaging this pull request! I think #1151 will NOT be resolved by this changes.

Yes, you're correct! I'm thing rewriting the derive macros, without using sea_query::Iden derive macros.

Would you mind if I merge your PR into another local branch so I can work on top of your work?

I'll create a PR to fix both issues and ask for your help to validate the fix did works. Thanks in advance!! :)

This was unlinked from issues Oct 26, 2022
sea_orm::DeriveActiveEnum now requires some modules and types are imported since v0.10.0 #1143
Closed
DeriveActiveEnum requires sea-query #1151
Closed
@siketyan
Copy link
Contributor Author

@billy1624

Would you mind if I merge your PR into another local branch so I can work on top of your work?

Sure, of course!
So I leave it to you about sea_query stuff.

@billy1624 billy1624 changed the base branch from master to fix-enum-derive-imports October 26, 2022 06:22
@billy1624 billy1624 merged commit 9749d20 into SeaQL:fix-enum-derive-imports Oct 26, 2022
@siketyan siketyan deleted the fix-enum-derive-imports branch October 26, 2022 06:30
@billy1624 billy1624 mentioned this pull request Oct 26, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billy1624 billy1624 billy1624 left review comments

Assignees

@siketyan siketyan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siketyan @billy1624