Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enable --universal-time by default #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2023
Merged

Enable --universal-time by default #1420

merged 2 commits into from
Jan 29, 2023

Conversation

@tyt2y3
Copy link
Member

@tyt2y3 tyt2y3 commented Jan 24, 2023 •
edited
Loading

I think we can enable this by default on 0.11

Dependent: SeaQL/seaql.github.io#84

billy1624
billy1624 reviewed Jan 26, 2023
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good step forward! I think it's better to have a fallback option where the entity file is named with local time. Something like --local-time?

I'm more than happy to add that for you. What's your opinion?

@tyt2y3
Copy link
Member Author

tyt2y3 commented Jan 26, 2023 •
edited
Loading

I think --universal-time=false is always available
Unless we make --local-time https://docs.rs/clap/latest/clap/builder/struct.Arg.html#method.conflicts_with
It will be quite cumbersome, so I am fine with or without it.

@billy1624
Copy link
Member

Flag in clap does not take value unless it's an option. I.e. --universal-time=true clap-rs/clap#1649 (comment)

I'll go and add a --local-time flag and make it mutual exclusive to each other.

@tyt2y3 tyt2y3 merged commit a9aa139 into master Jan 29, 2023
@tyt2y3 tyt2y3 deleted the cli/params-1 branch January 29, 2023 02:56
@billy1624 billy1624 added this to the 0.11.x milestone Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billy1624 billy1624 billy1624 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.11.x

Development

Successfully merging this pull request may close these issues.

2 participants

@tyt2y3 @billy1624