Test cases improvement #1811
Test cases improvement #1811
Conversation
|
As discussed, the most needed test cases are for:
And we needed both unit testing e.g. https://github.com/SeaQL/sea-orm/blob/master/src/executor/paginator.rs#L299 https://github.com/SeaQL/sea-orm/blob/master/src/executor/cursor.rs#L308 and integration testing (which you are doing) to test the behaviour of |
| } | ||
|
|
||
| #[smol_potat::test] | ||
| pub async fn with_related() -> Result<(), sea_orm::DbErr> { |
There was a problem hiding this comment.
Add 1 more case: Cake -> Filling
There was a problem hiding this comment.
I see new test cases for Cake -> Vendor but not Cake -> Filling?
| cake_fruit_model(1, 1).into_mock_row(), | ||
| cake_fruit_model(2, 1).into_mock_row(), |
There was a problem hiding this comment.
It can't duplicate right? This should be for Filling?
| .into_connection(); | ||
|
|
||
| assert_eq!( | ||
| Cake::find().find_with_related(Fruit).all(&db).await?, |
There was a problem hiding this comment.
Same here, may be change this to Filling
🎉 Released In 0.12.3 🎉Thank you everyone for the contribution! |
PR Info
New Features
Bug Fixes
Breaking Changes
Changes