Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Throw error if none of the db rows are affected #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 5, 2021
Merged

Throw error if none of the db rows are affected #211

merged 5 commits into from
Oct 5, 2021

Conversation

billy1624
Copy link
Member

Resolve #181

@billy1624 billy1624 self-assigned this Sep 28, 2021
@billy1624 billy1624 marked this pull request as ready for review September 28, 2021 11:28
@billy1624 billy1624 force-pushed the error-no-record-updated branch from aaaf8bd to 966f7ff Compare September 30, 2021 02:31
@tyt2y3
Copy link
Member

tyt2y3 commented Sep 30, 2021

We need unit tests using the mock connection on this behaviour too

@billy1624
Copy link
Member Author

We need unit tests using the mock connection on this behaviour too

Added!

tyt2y3
tyt2y3 reviewed Sep 30, 2021
View reviewed changes
tyt2y3
tyt2y3 requested changes Sep 30, 2021
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed a problem. this behavior should only applies to update_one, while for update many, it's fine to have updated 0 rows.

@billy1624
Copy link
Member Author

I have noticed a problem. this behavior should only applies to update_one, while for update many, it's fine to have updated 0 rows.

Fixed

@tyt2y3 tyt2y3 merged commit 125ee40 into master Oct 5, 2021
@tyt2y3 tyt2y3 deleted the error-no-record-updated branch October 5, 2021 14:01
tyt2y3 added a commit that referenced this pull request Oct 7, 2021
@tyt2y3
Merge pull request #211 from SeaQL/error-no-record-updated
30b9007 
Throw error if none of the db rows are affected
arpancodes pushed a commit to arpancodes/sea-orm that referenced this pull request Apr 8, 2022
@billy1624
feat: add ColumnType unsigned integer types (SeaQL#211)
b78acb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@billy1624 billy1624

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change the behavior of update() to return error when rows_affected is 0

2 participants

@billy1624 @tyt2y3