feat: Allow returning syntax for MariaDB #2710
Conversation
* Add new `"mariadb"` feature flag. * Check for it when matching the MySql backend to know if DB backend supports "returning" syntax.
| sqlx-mysql = ["sqlx-dep", "sea-query-binder/sqlx-mysql", "sqlx/mysql"] | ||
| sqlx-postgres = ["sqlx-dep", "sea-query-binder/sqlx-postgres", "sqlx/postgres", "postgres-array"] | ||
| sqlx-sqlite = ["sqlx-dep", "sea-query-binder/sqlx-sqlite", "sqlx/sqlite"] | ||
| mariadb = ["sqlx-mysql"] |
There was a problem hiding this comment.
Hi, thanks for the contribution!
Regarding feature flag names, I feel MariaDB is a bit vague. I think the following options are clearer:
(with-)mariadb-returningif we want more fine-grained feature control.(with-)mariadb-dialectif we intend to group all MariaDB-specific features under this flag.
There was a problem hiding this comment.
I also think that implicitly enabling sqlx-mysql is unnecessary.
There was a problem hiding this comment.
I agree with you. let's go with mariadb-use-returning to be more consistent with sqlite-use-returning-for-3_35.
I;'ll make the change after merge.
* Add new `"mariadb"` feature flag. * Check for it when matching the MySql backend to know if DB backend supports "returning" syntax.
🎉 Released In 1.1.17 🎉Thank you everyone for the contribution! |
PR Info
exec_with_returning_manywith MariaDB #2709.New Features
"mariadb"feature flag.