Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allowed None for max_lifetime and idle_timeout Parameters #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allowed None for max_lifetime and idle_timeout Parameters #2748

wants to merge 1 commit into from
+2 −6

Conversation

MinuraPunchihewa
Copy link

PR Info

Bug Fixes

  • This PR enables None values to be passed for the max_connections and idle_timeout parameters when creating database connections.

Huliiiiii
Huliiiiii requested changes Oct 12, 2025
View reviewed changes
@MinuraPunchihewa MinuraPunchihewa force-pushed the bugfix/allow_none_values branch from 562e47f to 353c180 Compare October 12, 2025 15:23
@MinuraPunchihewa MinuraPunchihewa changed the title Allowed None for max_connections and idle_timeout Parameters Allowed None for max_lifetime and idle_timeout Parameters Oct 12, 2025
@Huliiiiii Huliiiiii requested review from Expurple and tyt2y3 October 12, 2025 18:03
Expurple
Expurple reviewed Oct 20, 2025
View reviewed changes
Copy link
Member

@Expurple Expurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From quickly looking at the diff, it's not obvious why the other surrounding fields are still if let Some .... Seems like either a potential inconsistency or something that needs to be commented and maybe grouped together

@Huliiiiii
Copy link
Member

From quickly looking at the diff, it's not obvious why the other surrounding fields are still if let Some .... Seems like either a potential inconsistency or something that needs to be commented and maybe grouped together

https://github.com/launchbadge/sqlx/blob/ad2936a9c479214f90456102e218189d563f103d/sqlx-core/src/pool/options.rs#L161-L162

You are right, max_lifetime and idle_timeout should be changed to Option<Option<...>>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Expurple Expurple Expurple left review comments

@Huliiiiii Huliiiiii Huliiiiii approved these changes

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No way to set max_lifetime and idle_timeout to None for database connections

3 participants

@MinuraPunchihewa @Huliiiiii @Expurple