Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Added option to configure the grpc histogram#1143

Merged
adriangonz merged 2 commits intoSeldonIO:masterfrom
cristiancl25:feature/grpc-histogram
May 26, 2023
Merged

Added option to configure the grpc histogram#1143
adriangonz merged 2 commits intoSeldonIO:masterfrom
cristiancl25:feature/grpc-histogram

Conversation

@cristiancl25
Copy link

@cristiancl25 cristiancl25 commented May 11, 2023

No description provided.

@cristiancl25 cristiancl25 mentioned this pull request May 11, 2023
Closed
adriangonz
adriangonz reviewed May 17, 2023
View reviewed changes
Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @cristiancl25 !

Thanks for contributing this change. I think it's pretty reasonable - in fact, I was wondering whether it would make sense to remove the setting and always keep the enable_handling_time_histogram flag enabled?

adriangonz
adriangonz approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @cristiancl25 !

PR looks great now. Once tests are green, we can go ahead with this one. 🚀

@adriangonz
Copy link
Contributor

adriangonz commented May 23, 2023

FYI that tests failure seems unrelated to this PR (should get fixed by #1164). Once that's merged, it may be good to rebase this PR and re-trigger the tests.

image

@adriangonz
Copy link
Contributor

adriangonz commented May 23, 2023

Hey @cristiancl25 , the fix for the test issue above has already been merged. Could you rebase from master when you get a chance?

@cristiancl25 cristiancl25 force-pushed the feature/grpc-histogram branch from 8f26815 to 02ed6f5 Compare May 24, 2023 20:05
@cristiancl25
Copy link
Author

cristiancl25 commented May 24, 2023

Done!

@adriangonz
Copy link
Contributor

adriangonz commented May 26, 2023

Thanks for rebasing it! It should be ready to go now 👍

@adriangonz adriangonz merged commit 237df76 into SeldonIO:master May 26, 2023
adriangonz pushed a commit that referenced this pull request May 26, 2023
Added option to configure the grpc histogram (#1143)
9722a3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adriangonz adriangonz adriangonz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cristiancl25 @adriangonz