Use TypedArrays instead of Nodejs' Buffer #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShogunPanda
approved these changes
May 2, 2024
Owner
ShogunPanda
left a comment
There was a problem hiding this comment.
Just a little nit, the rest looks go to me!
Thanks a lot!
| const textDecoder = new TextDecoder() | ||
|
|
||
| function loadWASM() { | ||
| return require('node:fs').readFileSync(require('node:path').resolve(__dirname, 'milo.wasm')) |
Owner
There was a problem hiding this comment.
For the browser environment this will not work. But we don't need to change this as milo already exports a index-with-wasm (probably I should rename this) which embeds the WASM file inside.
Owner
|
Once you remove the change in the builder file, I'll merge this. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
This lets this parser be used from more environments, namely browsers. #4 has more context.
https://sindresorhus.com/blog/goodbye-nodejs-buffer has some context on why we should move on from NodeJS buffers.
Probably also closes #3, because I updated the instructions as a side effect and didn't see that PR.