Appease linter #813
Closed
Appease linter #813
+5
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| stop | ||
| @pid_controller.reset | ||
| end | ||
|
|
There was a problem hiding this comment.
why are we deleting these functions? 🤔
There was a problem hiding this comment.
They were duplicated
| rescue | ||
| end | ||
|
|
||
| @breaker.acquire(@resource) { raise "Error" } |
There was a problem hiding this comment.
wouldn't this break the test?
| # Simulate dependency failures | ||
| 10.times do | ||
| @breaker.acquire(@resource) { raise "Error" } | ||
| rescue |
There was a problem hiding this comment.
same comment as above
| write_thread.join | ||
| read_threads.each(&:join) | ||
|
|
||
| # Should complete without deadlock or errors |
There was a problem hiding this comment.
this might be needed. What is the test trying to confirm?
|
Followed up in #812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicated functions and fix lines upsetting the linter