Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@tanema
Copy link
Contributor

@tanema tanema commented Jun 26, 2017

WHAT are you trying to accomplish with this PR?

fixes #417

  • Added wildcards to environment variables however depending on your shell you will probably need quotation marks around any wildcards like: theme --env="client-*" uplodate
  • Added the ability to use multiple env flags like: theme --env=production --env=development upload

WHY are you choosing this approach?

To implement having several selected environments/clients loaded at one time I had to implement having the ability to load independent environments. This added the ability for multiple env flags which I think is a good feature to have as well.

HOW is this accomplished?

Changed how environments/theme clients are loaded to have a environment name matcher.

Anything that could go wrong?

Tests have been added for all situation for loading environment. This seems low risk

Checklist

  • It is safe to simply rollback this change.
  • I have 🎩'd these changes by using the commands I changed by hand

@tanema tanema requested a review from chrisbutcher June 26, 2017 18:08
@tanema tanema merged commit 9a35da0 into master Jun 27, 2017
@tanema tanema deleted the more_flexible_env_flag branch June 27, 2017 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Wildcard environments

2 participants