Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@tanema
Copy link
Contributor

@tanema tanema commented Aug 15, 2017

While doing QA I realized that once a file is in the manifest and the timestamp is updated, the file will no longer be downloaded if the file is deleted.

Previously while pruning files from the manifest I would only prune a file if it didn't exist on remote as well as on disk however I have changed it to prune files that only don't exist on the disk. This is better because it doesn't matter if the file is still on the remote. The user cannot update/overwrite file changes if the file does not exist. Now that the file will be pruned from the manifest if it didn't exist, this means it will be downloaded when download is called since it no longer exists in the manifest.

@tanema tanema merged commit 98fe4eb into master Aug 15, 2017
@tanema tanema deleted the fixing_prune_to_prune_files_not_on_disk branch August 15, 2017 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant