Prune now only prunes files not on disk #438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing QA I realized that once a file is in the manifest and the timestamp is updated, the file will no longer be downloaded if the file is deleted.
Previously while pruning files from the manifest I would only prune a file if it didn't exist on remote as well as on disk however I have changed it to prune files that only don't exist on the disk. This is better because it doesn't matter if the file is still on the remote. The user cannot update/overwrite file changes if the file does not exist. Now that the file will be pruned from the manifest if it didn't exist, this means it will be downloaded when download is called since it no longer exists in the manifest.