Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Refresh]: Remove install stuffs from refresh since in refresh should only renew provisioning profiles #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2025
Merged

[Refresh]: Remove install stuffs from refresh since in refresh should only renew provisioning profiles #846

merged 1 commit into from
Jan 19, 2025

Conversation

@mahee96
Copy link
Member

@mahee96 mahee96 commented Jan 19, 2025 •
edited
Loading

Changes

  • commented all install related code (which was used for reinstalling sidestore at end of refresh)
  • Need beta testers for both paid and free account testers
  • Suspecting if something that had to do with tampering the app-bundle expecting a re-install of sidestore then it would be broken now (and this is fine, coz we need separation of concerns anyway, so we can fix such issues once someone reports it)
  • One example is, changing appIcon, i think current implementation marks icon is changed and it is updated when reinstalling, but these are non-issues (ie not major ones)
  • Fix shortcut refresh not working bug

Todo before merge

  • Finish beta testing for 7 days free accts
  • Test

@github-actions
Copy link

Builds for this Pull Request are available at
SideStore-0.6.0-pr.846+7e5fa23.ipa
SideStore-0.6.0-pr.846+7e5fa23-dSYM
Have a nice day.

@nythepegasus nythepegasus merged commit 332f563 into SideStore:develop Jan 19, 2025
1 check passed
This was referenced Feb 1, 2025
Open
Closed
@Harishwarrior
Copy link

Is this why refresh is much faster now?

@mahee96
Copy link
Member Author

mahee96 commented Feb 20, 2025

Yeah the refresh just renews the profiles (at most 3-5 secs) and doesn’t need reinstalling anything

@Harishwarrior
Copy link

Yeah the refresh just renews the profiles (at most 3-5 secs) and doesn’t need reinstalling anything

Excellent work. Fast af now! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nythepegasus nythepegasus nythepegasus approved these changes

@JoeMatt JoeMatt Awaiting requested review from JoeMatt JoeMatt is a code owner

@lonkelle lonkelle Awaiting requested review from lonkelle lonkelle is a code owner

@Spidy123222 Spidy123222 Awaiting requested review from Spidy123222 Spidy123222 is a code owner

@SternXD SternXD Awaiting requested review from SternXD SternXD is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mahee96 @Harishwarrior @nythepegasus