Thanks to visit codestin.com
Credit goes to github.com

Skip to content

WIP: Fixes for migration issues when migrating from 0.5.9 to 0.6.0 #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2025
Merged

WIP: Fixes for migration issues when migrating from 0.5.9 to 0.6.0 #920

merged 3 commits into from
Mar 26, 2025

Conversation

@mahee96
Copy link
Member

@mahee96 mahee96 commented Mar 23, 2025 •
edited
Loading

Issue when migrating from 0.5.10 to 0.6.0

  • 0.6.0 had the unique constraints set for AppPermissions on newly added field appBundleID and sourceID.
  • But these fields are pseudo attributes of the app-permission, ie not present in incoming json.
  • Due to this, the fields were initialized to nil and this caused ambiguity, failing the unique constraint requirement for AppPermission entity.

Fixes (Changes):

  • Retain unique constraint on the pseudo (added) attributes appBundleID, sourceID on the AppPermission.
  • update xcmappingmodel for to compensate for them by initializing these fields when source and storeApp's relationships are created.
  • Do similarly for other entities such as ReleaseTrack, AppScreenshot so that there aren't duplicates.
  • the p-key is now usually comprised of sourceID+appBundleID+...

Unique changes:

  • Since v0.6.0 is already released and has the problematic AppPermission schema, making the AppPermission have nil values for appBundleID, sourceID, and type/permission fields, We had to create a new direct mapping from v0.5.9 directly to v0.6.1 and another one for 0.6.0 to 0.6.1 though we already had progressive migration enabled.

Test cases:

  • Case-1:
    • delete existing installation if any and install 0.5.9 or 0.5.10 on simulator
    • Add all recommended sources in 0.5.9 or 0.5.10
    • Now install 0.6.1 on top of existing installation to make this an update
    • when sidestore 0.6.1 launches it works without any issues (try refreshing by scrolling down on the news page).
  • Case-2:
    • delete existing installation if any and install 0.6.0 on simulator
    • Add all recommended sources in 0.6.0
    • Now install 0.6.1 on top of existing installation to make this an update
    • when sidestore 0.6.1 launches it works without any issues (try refreshing by scrolling down on the news page).
  • Case-3:
    • delete existing installation if any and install 0.6.1 on simulator
    • Add all recommended sources in 0.6.0
    • Now refresh by scrolling down on the news page.

Results:

  • With this change, existing 0.5.10 and 0.6.0 users should now be able to seamlessly migrate to 0.6.1.

Closes the following issues:

@mahee96 mahee96 closed this Mar 23, 2025
@mahee96 mahee96 reopened this Mar 23, 2025
@mahee96
Copy link
Member Author

mahee96 commented Mar 23, 2025

Fr now, this is work in progress, I am there almost 90%, few issues to take care of related to the migration and post migration validations when upgrading to 0.6.1 which fixes issues in 0.6.0 startup.

users must be able to migrate from both AltStore_v11(0.5.9, 0.5.10) model and AltStore_v17(0.6.0) model to latest AltStore_v17(0.6.1)

@mahee96 mahee96 self-assigned this Mar 23, 2025
@github-actions
Copy link

Builds for this Pull Request are available at
SideStore-0.6.1-pr.920+a7496e0.ipa
SideStore-0.6.1-pr.920+a7496e0-dSYM
Have a nice day.

@github-actions
Copy link

Builds for this Pull Request are available at
SideStore-0.6.1-pr.920+a7496e0.ipa
SideStore-0.6.1-pr.920+a7496e0-dSYM
Have a nice day.

@mahee96
Copy link
Member Author

mahee96 commented Mar 24, 2025

okay now fix is 100% complete....need to fill in the changeling of PR

@github-actions
Copy link

Builds for this Pull Request are available at
SideStore-0.6.1-pr.920+a4dfd28.ipa
SideStore-0.6.1-pr.920+a4dfd28-dSYM
Have a nice day.

@github-actions
Copy link

Builds for this Pull Request are available at
SideStore-0.6.1-pr.920+e553efb.ipa
SideStore-0.6.1-pr.920+e553efb-dSYM
Have a nice day.

@mahee96
Copy link
Member Author

mahee96 commented Mar 24, 2025

Fixes #904

@mahee96 mahee96 mentioned this pull request Mar 24, 2025
Closed
@mahee96
Copy link
Member Author

mahee96 commented Mar 26, 2025

will merge for now, if more issues occur will create new PR.

@mahee96 mahee96 merged commit 9771f6b into SideStore:develop Mar 26, 2025
1 check passed
@nbycoder nbycoder mentioned this pull request Apr 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeMatt JoeMatt Awaiting requested review from JoeMatt JoeMatt is a code owner

@lonkelle lonkelle Awaiting requested review from lonkelle lonkelle is a code owner

@nythepegasus nythepegasus Awaiting requested review from nythepegasus nythepegasus is a code owner

@Spidy123222 Spidy123222 Awaiting requested review from Spidy123222 Spidy123222 is a code owner

@SternXD SternXD Awaiting requested review from SternXD SternXD is a code owner

Assignees

@mahee96 mahee96

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Unable to launch sidestore after updating from 0.5.10 to 0.6.0 stable

1 participant

@mahee96