-
Notifications
You must be signed in to change notification settings - Fork 16
Add welcome window (with Terms and Conditions) #106
Conversation
| @@ -0,0 +1,88 @@ | |||
| import React from 'react' | |||
|
|
|||
| function ToS () { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably fetch this content from an URL to be always sure to have the latest content.
https://siderus.io/tos.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refused to display 'https://siderus.io/tos.html' in a frame because it set 'X-Frame-Options' to 'deny'
We need to allow CORS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will a download work? You don’t need to use an iFrame, but we could download the content and then display it. What do you say?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. We should keep in mind though that it relies on an internet connection, but I guess that shouldn't be a problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it already relies on it due to the Siderus Network
| <ToS /> | ||
| </TermsSection> | ||
| <CheckBox | ||
| label="I accept terms and conditions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to "I have read and I agree to Siderus Terms and Conditions and Privacy policy"
Can in case change the Terms and Conditions and Privacy Policy to links that will open in the browser? :S
koalalorenzo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 👍
What changed?
Instead of the loading window, now we show the welcome window (which ToS) until you have accepted them.
Fixes: https://dev.siderus.team/issues/115