This repository was archived by the owner on Jul 7, 2024. It is now read-only.
Remove shared ipfs api instance to one per window #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Now each window has its own api connection, the client is no longer shared between them.
There is a significant performance drop which can be seen (the time after the loading wheel disappears until the data is loaded into the component).
What we can do is add a loading wheel to show the data is loading, but is this the solution we want?
Note that the bug https://dev.siderus.team/issues/125 is fixed by this change, we can now download
QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn.