Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 7, 2024. It is now read-only.

Feature/detach cli functions #182

Merged
kernelwhisperer merged 4 commits into from
Aug 25, 2018
Merged

Feature/detach cli functions #182

kernelwhisperer merged 4 commits into from
Aug 25, 2018

Conversation

@kernelwhisperer
Copy link
Contributor

@kernelwhisperer kernelwhisperer commented Aug 25, 2018

What changed?

Moved the following functions from daemon.js to api.js

  getSiderusPeers,
  connectToCMD,
  addBootstrapAddr,
  promiseRepoUnlocked,
  getAPIVersion

@koalalorenzo
Copy link
Member

koalalorenzo commented Aug 25, 2018

Tests!

koalalorenzo
koalalorenzo approved these changes Aug 25, 2018
View reviewed changes
Copy link
Member

@koalalorenzo koalalorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kernelwhisperer kernelwhisperer merged commit 1254b1f into master Aug 25, 2018
@kernelwhisperer kernelwhisperer deleted the feature/detach-cli-functions branch August 25, 2018 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@koalalorenzo koalalorenzo koalalorenzo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kernelwhisperer @koalalorenzo