[angular][xmcloud] Do not initialize CloudSDK if we are in edit or preview mode #1961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preview mode or missing route data
illiakovalenko
approved these changes
Oct 30, 2024
|
@yavorsk Another thing that I observed, that when I navigate using client side routing - cloudsdk is initialized on each route change, while it should be initialized once, on the first visit. Also I don't know if it's fine for cloudsdk if "init" will be called multiple times |
illiakovalenko
requested changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This PR modifies cloudsk init component to not initialize CloudSDK in the browser if we are in edit or preview mode or route data is missing.
Testing Details
Types of changes