This repository was archived by the owner on Jun 14, 2023. It is now read-only.
fix(tracer): fixed create exit span with context error when current context not to be sampled #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontext not to be sampled In the tracer CreateExitSpanWithContext function, when the context not to be sample in this time, it will be return a "span type is wrong" error. Because trying to check the span is NoopSpan when after called CreateLocalSpan function, the convertion is expected a struct value. But actual, the CreateLocalSpan function return a Span is a interface type, a interface type is a pointer in golang. So we need to change the convertion to expect a pointer of NoopSpan type. fix SkyAPM#113
|
@arugal Please review this fix, thank you |
kagaya85
approved these changes
Nov 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the tracer CreateExitSpanWithContext function, when the context is not a sample in this time, it
will be return a "span type is wrong" error.
Because trying to check the span is NoopSpan when after called CreateLocalSpan function, the convertion is expected a struct value.
But actual, the CreateLocalSpan function return a Span is a interface type, a interface type is a pointer in golang.
So we need to change the convertion to expect a pointer of NoopSpan type.
fix #113