Process args in to Server instead of mutating & referencing args in the program #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-Colvin
commented
Jul 29, 2025
| args: Args; | ||
| quit := false; | ||
|
|
||
| // This is from the config file |
Contributor
Author
There was a problem hiding this comment.
Removed because misleading: roots et al are discovered if not set to anything in config.
| log_error("Could not parse arguments"); | ||
| exit(1); | ||
| } | ||
| log("Args are %", args); |
Contributor
Author
There was a problem hiding this comment.
subtle difference in logging here. Previously the code logged the args including the result of any compiler path finding work, now it does not, which seems fine as a) more honest w.r.t. actual passed args & b) the compiler path finding has its own logging.
fc5c9e8 to
75dafc4
Compare
dccc583 to
5e3b98c
Compare
John-Colvin
commented
Sep 2, 2025
| verbose: bool; | ||
| profile: bool; | ||
| jai_path: string; | ||
| jai_exe_name: string; |
Contributor
Author
There was a problem hiding this comment.
having this in Args seemed a bit of a hack to me, seeing as it wasn't actually settable from the cli or even the config. But now we don't need it here, it just lives in server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for some separation between what the user asked for in args and what the internals reference. It makes things easier in a multi-project setting (the
serverbecomes per-project & should represent all the state for it, settings like jai path can be different per project). It also seems better prep for using Jails as a library.