-
Notifications
You must be signed in to change notification settings - Fork 80
์ฅ๋ง๊ฐ์ดํ ํธ์ถํ๋ ๊ฒฝ์ฐ KeyError์ ๋ํ ๋ฐฉ์ด์ฝ๋ ์ถ๊ฐํจ. #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
visualmoney
wants to merge
148
commits into
Soju06:main
Choose a base branch
from
visualmoney:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
โฆ๋์ค๊ฐ ์ ์ ๋์ํ๋์ง ํ์ธ 3. ์ง ์์ ์๋ธํด๋์ค๋ ์ฌ์ ํ ์ถ์์ผ๋ก ์ทจ๊ธ๋๋์ง ํ์ธ)
โฆ๋ฅผ ์กฐ์ ํ๋ ๋ฆฌํฉํ ๋ง (test_cache.py ์์ ์๋ฃ)
โฆetion - Add CLAUDE.md: AI development guide with documentation structure - Add dev_logs/2025-12-18_phase1_week1_complete.md: detailed development log - Add prompts/2025-12-18_public_api_refactor.md: prompt tracking - Add reports/2025-12-18_phase1_week1_complete_report.md: completion report - Update ARCHITECTURE_REPORT_V3_KR.md: mark Week 1 as complete Establishes documentation workflow: - prompts/ - user request tracking - dev_logs/ - daily development logs - reports/ - phase completion reports - guidelines/ - coding standards (planned) Week 1 achievements: - Public API reduced from 154 to ~15 items - Type separation system implemented - Backward compatibility maintained - 831 tests passing, 93% coverage
- Add four basic examples (quote, balance, place order with safety, realtime price) and README in examples/01_basic - Enhance QUICKSTART.md with next steps, troubleshooting, FAQ - Link QUICKSTART and examples from README Phase 1 Week 2 kickoff: example set prepared with safety guard for live trades
- Update examples to use KisAuth with virtual flag from config.yaml - Enhance examples/01_basic/README with detailed setup instructions - config.yaml template should contain actual credentials to run examples - hello_world.py verified and working
โฆe architecture report - Created 05 intermediate examples (01_multiple_symbols, 02_conditional_trading, 03_portfolio_analysis, 04_monitoring_dashboard, 05_advanced_order_types) - Created 03 advanced examples (01_scope_api_trading, 02_performance_analysis, 03_error_handling) - Added SIMPLEKIS_GUIDE.md with complete beginner guide - Updated ARCHITECTURE_REPORT_V3_KR.md with Week 1-4 completion status - Added comprehensive README files for examples folder - SimpleKIS docs include create_client, save_config_interactive, and helper functions - All 832 tests passing, 92% code coverage maintained
- Week 4: ์ค๊ธ/๊ณ ๊ธ ์์ 8๊ฐ ์์ฑ ์๋ฃ (6.5์๊ฐ) - Phase 1 ์๋ฃ: ๊ณต๊ฐ API ์ ๋ฆฌ(15420), ์์ 13๊ฐ, ํ ์คํธ 832๊ฐ - Phase 2 ์์ธ ๊ณํ: ๋ฌธ์ํ ์์ฑ, CI/CD ํ์ดํ๋ผ์ธ ๊ตฌ์ถ - Phase 3 ์์ธ ๊ณํ: ์ปค๋ฎค๋ํฐ ํ์ฅ, ํํ ๋ฆฌ์ผ ๋ฐ ์๋ฌธ ๋ฌธ์ - Phase 4 ๊ณํ: ๊ธ๋ก๋ฒ ๋ฌธ์, ์ฑ๋ฅ ์ต์ ํ, ์ ๊ท ์์ฅ ์ง์ - pykis/types.py ๋ฌธ์ ์ ๋ฐ์ดํธ: 130+ ๋ผ์ธ ๋ชจ๋ ๋ฌธ์ ์ถ๊ฐ - ๋ณด๊ณ ์ ๊ตฌ์กฐ ์ ๋ฆฌ: 4.3~4.9 ์น์ ๋ช ํํ
โฆANTUML_SETUP.md with run/verify instructions
โฆevent Korean text garbling in installer script
โฆ roadmap and Phase sections
โฆoptions; chore(project): update pyproject metadata
- Add public type separation policy to ARCHITECTURE.md - Create comprehensive CONTRIBUTING.md guide - Implement API reference auto-generation script - Create v2.2.0 -> v3.0.0 MIGRATION_GUIDE.md - Add unit tests for multi-profile config loading - Update ARCHITECTURE_REPORT with Phase 2 progress Phase 2 Week 1-2 completed (16 hours) Next: CI/CD pipeline and expanded integration tests
docs: add dynamic versioning guide and report updates chore(dev): add pre-commit, ruff, pytest-benchmark - .github/workflows/ci.yml - .pre-commit-config.yaml - docs/developer/VERSIONING.md - tests/integration + tests/performance samples - pyproject: dev deps updates - report: Week 3-4 kickoff
โฆrsioning with Poetry option C
โฆive review report with implementation checklists
- CI/CD: OS ๋งคํธ๋ฆญ์ค ํ์ฅ (3OS 2Python ๋ฒ์ ) - ์ปค๋ฒ๋ฆฌ์ง: fail_under=90 ์ ์ฑ ์ถ๊ฐ - pre-commit: 8๊ฐ ํ ์ค์ /์ต์ ํ - ํ ์คํธ: ํตํฉ/์ฑ๋ฅ ํ ์คํธ 14๊ฐ ์ถ๊ฐ - ์ค์ : .coveragerc, ci.yml, publish.yml ์ ๋ฐ์ดํธ - ์ํคํ ์ฒ: ARCHITECTURE_REPORT_V3_KR.md ์๋ฃ ํญ๋ชฉ ํ์
- ์์ธ ํด๋์ค: 3๊ฐ 13๊ฐ ํ๋ (KisConnectionError, KisAuthenticationError, KisRateLimitError, KisServerError, KisTimeoutError ๋ฑ) - Retry ๋ฉ์ปค๋์ฆ: exponential backoff + jitter (sync/async ๋ชจ๋ ์ง์) - JSON ๋ก๊น : JsonFormatter ํด๋์ค ์ถ๊ฐ (ELK/Datadog ํธํ) - ๋ก๊ทธ ๋ ๋ฒจ ๊ณ์ธตํ: DEBUG/INFO/WARNING/ERROR (์์ ๊ตฌ๋ถ) - ํ ์คํธ: 31๊ฐ ์ถ๊ฐ (exceptions 17 + logging 14) - ์ฝ๋: ~500์ค ์ ๊ท ์ถ๊ฐ - ์ํคํ ์ฒ ๋ฌธ์: Phase 3 Week 1-2 ์์ฑ ๋งํฌ ์ถ๊ฐ
- FAQ: 23๊ฐ Q&A (์ค์น, ์ธ์ฆ, ์์ธ, ์ฃผ๋ฌธ, ๊ณ์ข, ์๋ฌ์ฒ๋ฆฌ, ๊ณ ๊ธ์ฌ์ฉ๋ฒ) - NEWSLETTER_TEMPLATE: ์๊ฐ ๋ด์ค๋ ํฐ ํ ํ๋ฆฟ - CONTRIBUTING: FAQ 6-8๋ฒ ์ถ๊ฐ (์ฌ์๋, JSON ๋ก๊น , ์์ธ ์ฒ๋ฆฌ) - Jupyter Notebook: ์ด๊ธ ํํ ๋ฆฌ์ผ (11๊ฐ ์น์ ) - ์์ธ ์กฐํ, ์ฃผ๋ฌธ ์คํ, ์๋ฌ ์ฒ๋ฆฌ, ์๋ ์ฌ์๋ - ์ค์ต์ฉ ์ฝ๋ (์ฃผ์ ์ฒ๋ฆฌ) ๋ฌธ์ ์ถ๊ฐ: 3๊ฐ ์ฝ๋ ๋ผ์ธ: ~700์ค ์์ ๊ณต์: 4-5์๊ฐ
- MULTILINGUAL_SUPPORT.md: ๋ค๊ตญ์ด ์ง์ ์ ๋ต (650์ค)
๋ฌธ์ ๊ตฌ์กฐ (docs/user/{ko,en}/)
๋ฒ์ญ ๊ท์น ๋ฐ ์ฉ์ด์ฌ์
๋ฒ์ญ ํ๋ก์ธ์ค & ํ์ง ๊ธฐ์ค
์๋ ๋ฒ์ญ CI/CD ๊ณํ
๋ฒ์ญ์ ์ปค๋ฎค๋ํฐ ์์คํ
- REGIONAL_GUIDES.md: ์ง์ญ๋ณ ์ค์ ๊ฐ์ด๋ (800์ค)
ํ๊ตญ: ์ค์ ๊ฑฐ๋, ํ
์คํธ ํ๊ฒฝ
๊ธ๋ก๋ฒ: Mock ํ๊ฒฝ, ๊ฐ๋ฐ์ ๊ฐ์ด๋
๊ฑฐ๋ ์๊ฐ ๊ด๋ฆฌ (์๊ฐ๋, ํด์ฅ์ผ)
์ง์ญ๋ณ ํน์ ์ค์
- API_STABILITY_POLICY.md: API ์์ ์ฑ ์ ์ฑ
(650์ค)
API ์์ ์ฑ ๋ ๋ฒจ ์ ์ (Stable/Beta/Deprecated/Removed)
Semantic Versioning ์ ์ฑ
Breaking Change ๋ง์ด๊ทธ๋ ์ด์
(3๋จ๊ณ, 6๊ฐ์ ์ ์)
๋ฒ์ ๋ณ ์ง์ ๊ธฐ๊ฐ (12๊ฐ์)
ํธํ์ฑ ๋ณด์ฅ ๋ฒ์
- ์๋ฌธ ๊ณต์ ๋ฌธ์ (1,250์ค)
README.md: ํ๋ก์ ํธ ๊ฐ์ & Quick start (400์ค)
QUICKSTART.md: 5๋ถ ์๋ด์ (350์ค)
FAQ.md: 23๊ฐ Q&A ์๋ฌธ ๋ฒ์ญ (500์ค)
- ๊ฐ๋ฐ ๋ฌธ์
2025-12-20_phase4_global_expansion_prompt.md
2025-12-20_phase4_week1_global_docs_devlog.md
PHASE4_WEEK1_COMPLETION_REPORT.md
๋ฌธ์ ์ถ๊ฐ: 7๊ฐ (์ ๊ท)
์ฝ๋ ๋ผ์ธ: ~3,500์ค
์์ ์ฝ๋: 58๊ฐ
์ค์์ ์๊ฐ: 6์๊ฐ (์์ : 14-16์๊ฐ)
ํจ์จ์ฑ: 166% (์กฐ๊ธฐ์๋ฃ 40%)
โฆchecklist - Mark Phase 2 Week 3-4 as completed (CI/CD, pre-commit, integration tests) - Add detailed Phase 1 implementation checklist with time estimates - Add current status (progress: ~15%, Phase 1 awaiting) - Add work priority breakdown (immediate, parallel, next steps) - Add final summary section with success criteria and completion checklist - Update version to V3.1 (2025-12-20 update)
- Mark Phase 1 as completed (public_types.py, __init__.py refactoring) - Update test status: 874 passed, 19 skipped - Coverage verification: 89.7% (target 90%, -0.3%) - Fix test___env__.py: Replace VERSION with __version__ - Fix test_exceptions.py: Use proper Mock response attributes - Add improvement recommendations and priorities - Update TODO checklist with detailed coverage improvement plan - Version: V3.2 (2025-12-20 verification complete)
- ์ํคํ ์ฒ ๋ฌธ์ 7๊ฐ ๋ชจ๋์ ํ์ผ๋ก ์ฌ๊ตฌ์ฑ (2,500์ค) * ARCHITECTURE_README_KR.md: ๋ค๋น๊ฒ์ด์ ๋ฐ ์ธ๋ฑ์ค * ARCHITECTURE_CURRENT_KR.md: ํํฉ ๋ถ์ ๋ฐ ์ํ * ARCHITECTURE_DESIGN_KR.md: ์ค๊ณ ํจํด ๋ฐ ์ํคํ ์ฒ * ARCHITECTURE_QUALITY_KR.md: ์ฝ๋ ํ์ง ๋ฐ ํ ์คํธ ๋ถ์ * ARCHITECTURE_ISSUES_KR.md: ์ด์ ์ถ์ (ํด๊ฒฐ/์งํ/์์ ) * ARCHITECTURE_ROADMAP_KR.md: ์คํ ๊ณํ ๋ฐ ์ผ์ * ARCHITECTURE_EVOLUTION_KR.md: v3.0.0 ์งํ ๋ฐ ๋ง์ด๊ทธ๋ ์ด์ - GitHub Discussions ๊ตฌ์ถ * question.yml, feature-request.yml, general.yml ํ ํ๋ฆฟ * GITHUB_DISCUSSIONS_SETUP.md ์ค์ ๊ฐ์ด๋ - Phase 4 ๊ธ๋ก๋ฒ ํ์ฅ ์๋ฃ * ์๋ฌธ ๋ฌธ์ 3๊ฐ (README, QUICKSTART, FAQ) * ๊ฐ์ด๋๋ผ์ธ 5๊ฐ (3,500์ค) * ํํ ๋ฆฌ์ผ ์์ ์คํฌ๋ฆฝํธ (600์ค) - ์ด์ ๋จ์ผ ๋ฌธ์ ์์นด์ด๋ธ (V1/V2/V3) ๋ฉํธ๋ฆญ: ์ด 5,650์ค ์ ๊ท ๋ฌธ์ ์์ฑ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ ๏ธ PR Summary
๐ ์์ฝ
์ด๋ค ๊ฒ์ด ๋ณ๊ฒฝ๋์๋์? ๊ฐ๋ตํ ์ค๋ช ํด์ฃผ์ธ์.
์ธ์ฆ ํ ํฐ์ ์๋์ผ๋ก ๊ด๋ฆฌํ๋ ๊ธฐ๋ฅ์ ์ถ๊ฐํ์ต๋๋ค.
๐ ์ฃผ์ ๋ณ๊ฒฝ ์ฌํญ
์ฃผ์ ๋ณ๊ฒฝ ์ฌํญ์ ์ ์ด์ฃผ์ธ์.
utils.workspace.pyํ์ผ์ ์ถ๊ฐํ์ต๋๋ค.PyKis ๋ผ์ด๋ธ๋ฌ๋ฆฌ์ ๊ฐ์ธ ์์ ๊ณต๊ฐ์ ๊ด๋ฆฌํ๋ ๊ธฐ๋ฅ์ ์ถ๊ฐํ์ต๋๋ค.
kis.py์์PyKis๋ฉ์ธ ํด๋์ค ์์ฑ์์ keep_token ์ธ์๋ฅผ ์ถ๊ฐํ์ต๋๋ค.keep_token์ด True์ด๋ฉด ์ธ์ฆ ํ ํฐ์ ๊ฐ์ธ ์์ ๊ณต๊ฐ์์ ์๋์ผ๋ก ๊ด๋ฆฌํฉ๋๋ค.
๐ฏ ๋ชฉ์ ๋ฐ ์ํฅ
๋ชฉ์ : ์ ์ด PR์ด ํ์ํ๊ฐ์?
์ธ์ฆ ํ ํฐ์ ์๋์ผ๋ก ๊ด๋ฆฌํ๋ ๊ธฐ๋ฅ์ ์ถ๊ฐํ์ฌ ๋ผ์ด๋ธ๋ฌ๋ฆฌ๋ฅผ ์์ฝ๊ฒ ์ฌ์ฉํ ์ ์๋๋ก ํฉ๋๋ค.
์ํฅ: ์ด ๋ณ๊ฒฝ ์ฌํญ์ด ์ด๋ค ์ํฅ์ ๋ฏธ์น๋์?
ํ ํฐ ๋ก๋ ๋ฐ ์ ์ฅ์ ์๋์ผ๋ก ์ฒ๋ฆฌํ๋ฏ๋ก ๋น์ ๋ฌธ ์ฌ์ฉ์๊ฐ ํ ํฐ์ ๊ด๋ฆฌํ๋ ๋ถ๋ด์ด ์ค์ด๋ญ๋๋ค.