Support for Solo5 unikernel lifecycle management on Muen & ABI increase #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use memory below 2 MB. This brings Solo5 unikernels in line with native Muen components and will make it possible to seamlessly use the existing (re-)initialization code for subject restart on top of Muen.
In platform_exit(), look up the event called "solo5_exit" and trigger it if it is present. This allows Muen systems to take action whenever Solo5 exits, e.g. immediately restart the unikernel.
For Intel x86 the movaps instruction requires an aligned memory operand, see Intel SDM Vol. 2B.
Collaborator
|
Thanks for your fix, I will redo the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits make it possible to (re-)use the existing Subject Lifecycle Management of Muen and also apply it to Solo5 unikernels. A possible use case is to configure automatic restarting of unikernels that invoke
solo5_exit().Increasing the ABI version is necessary due to the TLS changes. @dinosaure, maybe you prefer to squash this change into 806d40a, which would be fine by me.
Finally, the adjustment to
test_fpuhas become necessary to successfully run the test on Muen, otherwise a #GP exception is raised. I guess we were lucky with alignment on other x86 bindings. Note that I have only verified that the test works on Muen but CI should show us if it unexpectedly brokehvtor any of the others.Addendum: I manually ran the tests on Muen and the test that are expected to pass ran successfully.