Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Instagram Provider #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 20, 2018
Merged

Add Instagram Provider #51

merged 8 commits into from
Sep 20, 2018

Conversation

@Waynenabors
Copy link
Contributor

My first pull request so hopefully it makes sense.
This was started on the old repo here: https://github.com/NoamB/sorcery/pull/625/files

We are using this code with an approved Instagram client_id with public_scope and it works great.

@Ch4s3
Copy link
Contributor

Ch4s3 commented Mar 24, 2017

@Waynenabors Sorry for the delay! @athix What are your thoughts on rolling this our vs making it a separate gem?

@Waynenabors
Copy link
Contributor Author

Waynenabors commented Mar 28, 2017 •
edited
Loading

Fixes an issue where new Facebook Apps with API v2.8 are no longer compatible with v2.2 Oauth callback content/type. Starting with v2.3 the response is valid JSON. So if we can pick our API version we should be able to pick our parser. I would even make the argument that it should default to :automatic since that works now. But for now I just needed access to set config.facebook.parse.

@mzp
Copy link

mzp commented Mar 28, 2017

Fixes an issue where new Facebook Apps with API v2.8 are no longer compatible with v2.2 Oauth callback content/type.

I met this problem (and monkey patched). I appreciate if this facebook's changes are merged.

@joshbuker joshbuker mentioned this pull request Mar 29, 2017
Merged
@Ch4s3
Copy link
Contributor

Ch4s3 commented Nov 28, 2017

If someone can resolve the conflict, I'll merge this.

@joshbuker
Copy link
Member

Last update almost year ago, whoops. 😬

@joshbuker joshbuker merged commit 0e21ede into Sorcery:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshbuker joshbuker joshbuker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Waynenabors @Ch4s3 @mzp @joshbuker