fix(incidentio): Implement deduplication key generation for alerts #1296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also added that the extra labels will be merged to the metabase object so that they are accessible in incident.io |
…lication key generation and metadata merging
…ata merging and deduplication key generation
TwiN
requested changes
Sep 27, 2025
…n request body construction
|
@NerdySoftPaw Looks like the tests are failing |
@TwiN let me fix this very quick |
Co-authored-by: NerdySoftPaw <[email protected]>
…b-bfbc-51f7e660a41f Fix incidentio test failures by handling dynamic deduplication_key field
|
tests should be fixed @TwiN. |
|
Thank you for the contribution! |
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Oct 7, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/twin/gatus](https://github.com/TwiN/gatus) | minor | `v5.25.2` -> `v5.26.0` | --- ### Release Notes <details> <summary>TwiN/gatus (ghcr.io/twin/gatus)</summary> ### [`v5.26.0`](https://github.com/TwiN/gatus/releases/tag/v5.26.0) [Compare Source](TwiN/gatus@v5.25.2...v5.26.0) #### What's Changed - feat(alerting): Add support for n8n alerts by [@​TwiN](https://github.com/TwiN) in [#​1309](TwiN/gatus#1309) - feat(client): Support body placeholder for SSH endpoints by [@​yansh97](https://github.com/yansh97) in [#​1286](TwiN/gatus#1286) - feat(alerting): Add RESULT\_CONDITIONS in custom alert to have more information by [@​aalmenar](https://github.com/aalmenar) in [#​1086](TwiN/gatus#1086) - fix(alerting): Implement deduplication key generation for incidentio alerts by [@​NerdySoftPaw](https://github.com/NerdySoftPaw) in [#​1296](TwiN/gatus#1296) - fix(ui): Swap oldest/newest result time for SuiteCard.vue by [@​TwiN](https://github.com/TwiN) in [#​1308](TwiN/gatus#1308) - fix(alerting): Format link from Telegram alert description when sending message by [@​andriyor](https://github.com/andriyor) in [#​1200](TwiN/gatus#1200) - chore(deps): Update aws-sdk-go to aws-sdk-go-v2 by [@​TwiN](https://github.com/TwiN) in [#​1305](TwiN/gatus#1305) #### New Contributors - [@​NerdySoftPaw](https://github.com/NerdySoftPaw) made their first contribution in [#​1296](TwiN/gatus#1296) - [@​yansh97](https://github.com/yansh97) made their first contribution in [#​1286](TwiN/gatus#1286) - [@​andriyor](https://github.com/andriyor) made their first contribution in [#​1200](TwiN/gatus#1200) **Full Changelog**: <TwiN/gatus@v5.25.2...v5.26.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzUuNCIsInVwZGF0ZWRJblZlciI6IjQxLjEzNS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJpbWFnZSJdfQ==--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1689 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces deduplication key generation and improved metadata handling for incident.io alerting integration. The main changes are the addition of a function to generate a unique deduplication key for each alert and the merging of endpoint extra labels into the alert metadata.
Incident deduplication and metadata improvements:
generateDeduplicationKeyfunction indedup.goto create a unique deduplication key for each alert using endpoint key, alert type, description, and timestamp. This key is used to identify and group related incidents in incident.io.buildRequestBodyinincidentio.goto assign a deduplication key to alerts if not already present, ensuring proper incident grouping in incident.io.buildRequestBodyso that endpointExtraLabelsare combined with the provider's configured metadata, allowing for more detailed and context-rich incident reports.Fixes: #1293