Fix for issue #789. #790
Closed
Fix for issue #789. #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
In discussion with @sydb, also added Deja Vu Sans as the default Sans font. |
Member
peterstadler
left a comment
There was a problem hiding this comment.
I tested this locally on my MacBook and I was missing the DejaVu Sans font. I'm probably able to install this font but for really addressing issue #789 and providing sensible defaults across systems we might consider:
- to switch fonts depending on OS, or
- to check for availability of fonts on the system
Contributor
Author
|
Good point. @sydb didn't have Times New Roman, which was a surprise to me. So I think surfacing the two font parameters and documenting them is a better approach. |
1 similar comment
Contributor
Author
|
Good point. @sydb didn't have Times New Roman, which was a surprise to me. So I think surfacing the two font parameters and documenting them is a better approach. |
Contributor
Author
|
This doesn't seem like a practical approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides what I think is a useful default value for the romanFont parameter. @sydb Note that there were no errors in Test2, which suggests an area lacking coverage (specifically, Test2 is not doing diff checks of any generated .tex files).