heed @role of <sch:assert> and <sch:report>
#2611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
role= attribute of Schematron assertions & reports.
tuurma
approved these changes
Nov 1, 2024
HelenaSabel
approved these changes
Nov 1, 2024
Member
HelenaSabel
left a comment
There was a problem hiding this comment.
Note: tests fail here because the changes from PR #2609 are not incorporated in this branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we were only testing for "nonfatal" vs everything else. However (since oXygen gives user the choice of "info", "information", "warn", "warning", "error", or "fatal") we have several cases of other values. Changed code to check for any of the union of the values we actually have and the values oXygen has in its “sample values include” list.
I did not set a milestone for this because it is not for the 4.9.0 or some future release, it is for tomorrow’s 4.8.1 release.