fix dictionary example per #2718 #2746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks a bunch! |
Member
|
I think what we have here is certainly an improvement because it's addressing the ticket. @HelenaSabel if you agree, I will let you make the call to merge this in to dev and make it part of the 4.10 release this week. Given the unfortunate timing (@bansp can't review til next week), perhaps we accept the risk that we've introduced an error on the grounds that we did at least correct the problem. We can always open a new ticket to improve the new example for the next release if we need to do that! |
Member
|
I think it’s worth merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @bansp’s request, we have fixed the
@typevalues in an example and added a new example from LEX-0.This work brought to you per TEI Council by @sydb, @ebeshero, and @martinascholger.