Thanks to visit codestin.com
Credit goes to github.com

Skip to content

simplify content model of <arc> and <node> #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trishaoconnor merged 2 commits into from
Oct 6, 2025
Merged

simplify content model of <arc> and <node> #2762

trishaoconnor merged 2 commits into from
Oct 6, 2025

Conversation

@sydb
Copy link
Member

@sydb sydb commented Sep 5, 2025

Use

<elementRef key="label" minOccurs="0" maxOccurs="2"/>

rather than

    <sequence minOccurs="0">
      <elementRef key="label"/>
      <elementRef key="label" minOccurs="0"/>
    </sequence>

This is a fix for #2761, but is blocked until TEIC/Stylesheets#773 is fixed, perhaps by TEIC/Stylesheets#774.

@sydb sydb added this to the Guidelines 4.11.0 milestone Sep 5, 2025
@sydb sydb changed the title simplify content model of <arc> simplify content model of <arc> and <node> Sep 5, 2025
@sydb
Do same thing for the
64ec3cf 
content model of node, which turns out to be the same as arc
@sydb
Copy link
Member Author

sydb commented Sep 5, 2025

Note: turns out the content model of <node> is exactly the same, so I replaced it with the same. Thus changed it, too, at 64ec3cf.

@sydb sydb marked this pull request as ready for review September 29, 2025 16:13
@trishaoconnor
Copy link
Contributor

trishaoconnor commented Sep 29, 2025 •
edited
Loading

Stylesheets PR TEIC/Stylesheets#774 has been approved and merged and Stylesheets issue TEIC/Stylesheets#773 has been resolved and closed.

Re-ran the GitHub tests and this PR is passing tests now. Am currently testing locally and pending a successful outcome I am happy to merge this PR @HelenaSabel if you also agree that it is ready for merging.

trishaoconnor
trishaoconnor approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@trishaoconnor trishaoconnor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. I re-ran the GitHub tests and tested locally as well. The PR is now passing tests successfully and I approve merging.

@martindholmes
Copy link
Contributor

martindholmes commented Oct 4, 2025

I agree. Go for merge.

@trishaoconnor trishaoconnor merged commit 2d8eae7 into dev Oct 6, 2025
4 of 6 checks passed
@trishaoconnor trishaoconnor deleted the sydb_2761_arc_content branch October 6, 2025 13:54
@trishaoconnor trishaoconnor mentioned this pull request Oct 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trishaoconnor trishaoconnor trishaoconnor approved these changes

@HelenaSabel HelenaSabel Awaiting requested review from HelenaSabel

Assignees

@trishaoconnor trishaoconnor

Labels

Priority: Low TEI: Schema

Projects

None yet

Milestone

Guidelines 4.11.0

Development

Successfully merging this pull request may close these issues.

5 participants

@sydb @trishaoconnor @martindholmes @torstenroeder